You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dblotsky <gi...@git.apache.org> on 2017/09/13 00:29:17 UTC
[GitHub] cordova-docs pull request #729: Fixed up 'deployment' docs in README.md.
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/729
Fixed up 'deployment' docs in README.md.
- Restored `gulp build` command in lieu of `npm run serve` command.
- Tested and fixed suggested deployment commands.
- Removed redundant text.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dblotsky/cordova-docs dblotsky-deploy-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #729
----
commit a08fe2eb086c5f1d7f224659b92975381a7159dd
Author: Dmitry Blotsky <dm...@gmail.com>
Date: 2017-09-13T00:21:44Z
Fixed up 'deployment' docs in README.md. Restored 'gulp build' command in lieu of 'npm run serve' command. Tested and fixed suggested deployment commands. Removed redundant text.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs issue #729: Fixed up 'deployment' docs in README.md.
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-docs/pull/729
LGTM.
I personally prefer `npm run serve` over `node_modules/.bin/gulp build --prod` but can deal with it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request #729: Fixed up 'deployment' docs in README.md.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/729
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs issue #729: Fixed up 'deployment' docs in README.md.
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the issue:
https://github.com/apache/cordova-docs/pull/729
@stevesgill @audreyso @shazron please review when you have a moment.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org