You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2025/12/16 22:14:26 UTC
[PR] Add more common methods to ExecutorConfig shim [airflow]
o-nikolas opened a new pull request, #59532:
URL: https://github.com/apache/airflow/pull/59532
Executors like Celery use more advanced config methods so ExecutorConfig must be updated to support these before those executors can be moved to support multi-team airflow.
Also team-ify a few more operations in the Airflow config parser itself.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more common methods to ExecutorConfig shim [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #59532:
URL: https://github.com/apache/airflow/pull/59532#discussion_r2625079639
##########
airflow-core/tests/unit/core/test_configuration.py:
##########
@@ -188,6 +188,95 @@ def test_team_config_file(self):
assert test_conf.get("celery", "result_backend") == "FOO"
assert test_conf.get("celery", "result_backend", team_name="unit_test_team") == "BAR"
+ def test_getsection_with_team_name(self):
+ """Test getsection with team_name parameter."""
+ test_config = """[celery]
+result_backend = FOO
+worker_concurrency = 16
+
+[unit_test_team=celery]
+result_backend = BAR
+worker_concurrency = 32
+"""
Review Comment:
Fair enough, looks like the module uses a mixture of both. Perhaps a bit more the classic no-indent approach. But I can update my changes to use textwrap.dedent to not contribute to the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more common methods to ExecutorConfig shim [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #59532:
URL: https://github.com/apache/airflow/pull/59532#discussion_r2625084527
##########
airflow-core/tests/unit/core/test_configuration.py:
##########
@@ -188,6 +188,95 @@ def test_team_config_file(self):
assert test_conf.get("celery", "result_backend") == "FOO"
assert test_conf.get("celery", "result_backend", team_name="unit_test_team") == "BAR"
+ def test_getsection_with_team_name(self):
+ """Test getsection with team_name parameter."""
+ test_config = """[celery]
+result_backend = FOO
+worker_concurrency = 16
+
+[unit_test_team=celery]
+result_backend = BAR
+worker_concurrency = 32
+"""
Review Comment:
You do you, I just thought you may not have been aware since it's not a particularly common thing to run into.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more common methods to ExecutorConfig shim [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #59532:
URL: https://github.com/apache/airflow/pull/59532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more common methods to ExecutorConfig shim [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #59532:
URL: https://github.com/apache/airflow/pull/59532#discussion_r2625070516
##########
airflow-core/tests/unit/core/test_configuration.py:
##########
@@ -188,6 +188,95 @@ def test_team_config_file(self):
assert test_conf.get("celery", "result_backend") == "FOO"
assert test_conf.get("celery", "result_backend", team_name="unit_test_team") == "BAR"
+ def test_getsection_with_team_name(self):
+ """Test getsection with team_name parameter."""
+ test_config = """[celery]
+result_backend = FOO
+worker_concurrency = 16
+
+[unit_test_team=celery]
+result_backend = BAR
+worker_concurrency = 32
+"""
Review Comment:
Trivial non-blocking nitpick, I recently noticed we have `textwrap.dedent` in a few other places which allows us to keep python-friendly indentation in cases like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org