You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/21 05:40:48 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1439: arch/Toolchain.defs: Change all ARCROSSDEV to CROSSDEV

xiaoxiang781216 opened a new pull request #1439:
URL: https://github.com/apache/incubator-nuttx/pull/1439


   ## Summary
   ARCROSSDEV always equals to CROSSDEV, so it is no reason to keep ARCROSSDEV.
   
   ## Impact
   No visible change.
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #1439: arch/Toolchain.defs: Change all ARCROSSDEV to CROSSDEV

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1439:
URL: https://github.com/apache/incubator-nuttx/pull/1439


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #1439: arch/Toolchain.defs: Change all ARCROSSDEV to CROSSDEV

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1439:
URL: https://github.com/apache/incubator-nuttx/pull/1439#issuecomment-661653045


   Why not just define ARCROSSDEV for the three architectures that are missing it?   If we do remove it, than we should also remove the definitions of it.
   
   It is missing from from `mips32` `avr32` `avr` `mor1kx`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #1439: arch/Toolchain.defs: Change all ARCROSSDEV to CROSSDEV

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1439:
URL: https://github.com/apache/incubator-nuttx/pull/1439#issuecomment-661664549


   I did not see where you removed the `ARCROSSDEV` for arm in the diff UI, but I see it now. Sorry for the confusion.
   I think this is probably safe, I cannot think of a good reason for using a different binutils than the one that would have come with the rest of the cross toolchain.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1439: arch/Toolchain.defs: Change all ARCROSSDEV to CROSSDEV

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1439:
URL: https://github.com/apache/incubator-nuttx/pull/1439#issuecomment-661661087


   > Why not just define ARCROSSDEV for the three architectures that are missing it? If we do remove it, than we should also remove the definitions of it.
   > 
   > It is missing from from `mips32` `avr32` `avr` `mor1kx`
   
   I remove ARCROSSDEV because it is always same as CROSSDEV, which could also simplify user setup, but I can add ARCROSSDEV for `mips32` `avr32` `avr` `mor1kx` if you prefer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1439: arch/Toolchain.defs: Change all ARCROSSDEV to CROSSDEV

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1439:
URL: https://github.com/apache/incubator-nuttx/pull/1439#issuecomment-661661087


   > Why not just define ARCROSSDEV for the three architectures that are missing it? If we do remove it, than we should also remove the definitions of it.
   > 
   > It is missing from from `mips32` `avr32` `avr` `mor1kx`
   
   I remove ARCROSSDEV because it is always same as CROSSDEV, which could also simplify user setup, but I can add ARCROSS for `mips32` `avr32` `avr` `mor1kx` if you prefer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org