You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2017/01/02 11:59:45 UTC
Re: SONAR : Ignore "squid:RedundantThrowsDeclarationCheck"
On 31 December 2016 at 14:42, Philippe Mouawad
<ph...@gmail.com> wrote:
> Hello,
> Do you agree with Sonar rule which says:
> "Remove the declaration of thrown exception 'XXXX' which is a runtime
> exception."
>
>
> I personally don't , I find it sometimes useful to have it explicitely
> mentioned
>
> We have 65 "issues" of that type.
>
> I propose to exclude it.
OK in general, but not every possible RTE should be mentioned.
It can be useful to document particular RTEs that may be encountered,
especially if the caller is expected to deal with them.
For example Integer.parseInt throws NumberFormatException which is an RTE.
IMO it would be really silly to drop that from the signature.
> --
> Regards.
> Philippe
Re: SONAR : Ignore "squid:RedundantThrowsDeclarationCheck"
Posted by Philippe Mouawad <ph...@gmail.com>.
On Monday, January 2, 2017, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
>
>
> Am 2. Januar 2017 12:59:45 MEZ schrieb sebb <sebbaz@gmail.com
> <javascript:;>>:
> >On 31 December 2016 at 14:42, Philippe Mouawad
> ><philippe.mouawad@gmail.com <javascript:;>> wrote:
> >> Hello,
> >> Do you agree with Sonar rule which says:
> >> "Remove the declaration of thrown exception 'XXXX' which is a runtime
> >> exception."
> >>
> >>
> >> I personally don't , I find it sometimes useful to have it
> >explicitely
> >> mentioned
> >>
> >> We have 65 "issues" of that type.
> >>
> >> I propose to exclude it.
> >
> >OK in general, but not every possible RTE should be mentioned.
> >It can be useful to document particular RTEs that may be encountered,
> >especially if the caller is expected to deal with them.
> >
> >For example Integer.parseInt throws NumberFormatException which is an
> >RTE.
> >IMO it would be really silly to drop that from the signature.
> >
>
> +1
I think we're on the same page.
I with the help of Felix have excluded it for now.
>
> Felix
>
> >
> >> --
> >> Regards.
> >> Philippe
>
--
Cordialement.
Philippe Mouawad.
Re: SONAR : Ignore "squid:RedundantThrowsDeclarationCheck"
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 2. Januar 2017 12:59:45 MEZ schrieb sebb <se...@gmail.com>:
>On 31 December 2016 at 14:42, Philippe Mouawad
><ph...@gmail.com> wrote:
>> Hello,
>> Do you agree with Sonar rule which says:
>> "Remove the declaration of thrown exception 'XXXX' which is a runtime
>> exception."
>>
>>
>> I personally don't , I find it sometimes useful to have it
>explicitely
>> mentioned
>>
>> We have 65 "issues" of that type.
>>
>> I propose to exclude it.
>
>OK in general, but not every possible RTE should be mentioned.
>It can be useful to document particular RTEs that may be encountered,
>especially if the caller is expected to deal with them.
>
>For example Integer.parseInt throws NumberFormatException which is an
>RTE.
>IMO it would be really silly to drop that from the signature.
>
+1
Felix
>
>> --
>> Regards.
>> Philippe