[GitHub] srkukarni commented on a change in pull request #1750: Show stacktrace when Function fails

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #1750: Show stacktrace when Function fails
URL: https://github.com/apache/incubator-pulsar/pull/1750#discussion_r186885554
 
 

 ##########
 File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/Reflections.java
 ##########
 @@ -154,6 +154,7 @@ public static Object createInstance(String userClassName, java.io.File jar) {
         try {
             return createInstance(userClassName, loadJar(jar));
         } catch (Exception ex) {
+            ex.printStackTrace();
 
 Review comment:
   I feel the better approach is to actually throw the exception and let it bubble upwards

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services