You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "Will-Lo (via GitHub)" <gi...@apache.org> on 2023/06/30 22:33:28 UTC
[GitHub] [gobblin] Will-Lo opened a new pull request, #3712: Add tags to dagmanager metrics for extensibility
Will-Lo opened a new pull request, #3712:
URL: https://github.com/apache/gobblin/pull/3712
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
DagManager metrics due to being sent as a gauge in some backend system needs differentiation despite using the same ContextAwareMeter class.
This PR is to add tags (which are extensible) for metric emitting classes to check these tags to process before sending the metrics to their corresponding backend system
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3712: [GOBBLIN-1848] Add tags to dagmanager metrics for extensibility
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3712:
URL: https://github.com/apache/gobblin/pull/3712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3712: [GOBBLIN-1848] Add tags to dagmanager metrics for extensibility
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3712:
URL: https://github.com/apache/gobblin/pull/3712#issuecomment-1615256745
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3712](https://app.codecov.io/gh/apache/gobblin/pull/3712?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b144b94) into [master](https://app.codecov.io/gh/apache/gobblin/commit/5af6bca57df909e44b995e5b2d667c70e0399877?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5af6bca) will **decrease** coverage by `1.81%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3712 +/- ##
============================================
- Coverage 46.82% 45.02% -1.81%
+ Complexity 10804 2121 -8683
============================================
Files 2141 412 -1729
Lines 84429 17817 -66612
Branches 9383 2170 -7213
============================================
- Hits 39537 8022 -31515
+ Misses 41294 8936 -32358
+ Partials 3598 859 -2739
```
[see 1742 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3712/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org