You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/24 16:40:30 UTC

[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command

htran1 commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r287436214
 
 

 ##########
 File path: bin/gobblin-admin.sh
 ##########
 @@ -1,142 +0,0 @@
-#!/bin/bash
 
 Review comment:
   How about maintaining compatibility with callers of the old script? One option is to leave the old scripts as wrapper scripts that call the new one. Another option is to have the old script names be symlinks to the new script and detect the usage based on the value of $0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services