You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Adrian Nistor (JIRA)" <ji...@apache.org> on 2013/06/21 23:32:23 UTC
[jira] [Created] (WW-4126) Incorrect behavior for
ELSupport.containsNulls()
Adrian Nistor created WW-4126:
---------------------------------
Summary: Incorrect behavior for ELSupport.containsNulls()
Key: WW-4126
URL: https://issues.apache.org/jira/browse/WW-4126
Project: Struts 2
Issue Type: Bug
Components: Plugin - Embedded JSP
Affects Versions: 2.3.14.3
Environment: any
Reporter: Adrian Nistor
Attachments: patch2.diff, patch.diff
The incorrect behavior appears in version 2.3.14.3 and in revision
1495522. I attached a one-line patch (patch.diff) that fixes it.
Method "ELSupport.containsNulls" checks if the "Object[] obj" array
contains nulls like this:
{code:java|borderStyle=solid}
for (int i = 0; i < obj.length; i++) {
if (obj[0] == null) {
return true;
}
}
return false;
{code}
Instead of "obj[0]", the code should be "obj[i]", as in patch.diff.
If indeed the code is intended to check only "obj[0]", then there is
no need for a loop and the entire method body should be only "return
obj[0] == null;" (I attached patch2.diff, though it's unlikely that
this is the correct behavior).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira