You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/01 17:48:43 UTC

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-652560391


   Unfortunately the python test is taken by tox precommit suites - I suppose it shouldn't?
   Btw in which suites should this test be running? postCommitPortable?
   
   Other xlang tests have some skipIfs, e.g.:
   ```
   @unittest.skipUnless(
       os.environ.get('EXPANSION_PORT'))
   ```
   But they are really using those env variables and my test doesn't need any setup. How would you suggest to solve it?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org