You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/10 06:57:57 UTC
[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #223:
fix(protocol): delete string print in header decode and open test cases.
ShannonDing opened a new pull request #223: fix(protocol): delete string print in header decode and open test cases.
URL: https://github.com/apache/rocketmq-client-cpp/pull/223
## What is the purpose of the change
[ISSUE #111 ]fix(protocol): delete string print in header decode and open test cases.
## Brief changelog
1. delete string print in header decode
2. add test cases for command decode
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #223:
fix(protocol): delete string print in header decode and open test cases.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #223: fix(protocol): delete string print in header decode and open test cases.
URL: https://github.com/apache/rocketmq-client-cpp/pull/223#issuecomment-572904617
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b5b3b35f0a047799c4be1e11b8956cf00959f984?src=pr&el=desc) will **increase** coverage by `1.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 47.82% 49.64% +1.82%
==========================================
Files 173 173
Lines 10441 10607 +166
==========================================
+ Hits 4993 5266 +273
+ Misses 5448 5341 -107
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [test/src/producer/StringIdMakerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvZHVjZXIvU3RyaW5nSWRNYWtlclRlc3QuY3Bw) | `100% <ø> (ø)` | |
| [src/protocol/CommandHeader.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuY3Bw) | `73.04% <100%> (+26.14%)` | :arrow_up: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `66.15% <0%> (+16.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=footer). Last update [b5b3b35...5a6c640](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #223:
fix(protocol): delete string print in header decode and open test cases.
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #223: fix(protocol): delete string print in header decode and open test cases.
URL: https://github.com/apache/rocketmq-client-cpp/pull/223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #223:
fix(protocol): delete string print in header decode and open test cases.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #223: fix(protocol): delete string print in header decode and open test cases.
URL: https://github.com/apache/rocketmq-client-cpp/pull/223#issuecomment-572904617
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b5b3b35f0a047799c4be1e11b8956cf00959f984?src=pr&el=desc) will **increase** coverage by `2.84%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 47.82% 50.66% +2.84%
==========================================
Files 173 173
Lines 10441 10684 +243
==========================================
+ Hits 4993 5413 +420
+ Misses 5448 5271 -177
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [test/src/producer/StringIdMakerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvZHVjZXIvU3RyaW5nSWRNYWtlclRlc3QuY3Bw) | `100% <ø> (ø)` | |
| [test/src/protocol/ConsumerRunningInfoTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29uc3VtZXJSdW5uaW5nSW5mb1Rlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [src/protocol/CommandHeader.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuY3Bw) | `81.4% <100%> (+34.5%)` | :arrow_up: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [src/protocol/MessageQueue.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL01lc3NhZ2VRdWV1ZS5jcHA=) | `86.53% <0%> (+1.92%)` | :arrow_up: |
| [src/consumer/SubscriptionData.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL1N1YnNjcmlwdGlvbkRhdGEuY3Bw) | `43.33% <0%> (+8.33%)` | :arrow_up: |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `70.76% <0%> (+21.56%)` | :arrow_up: |
| [src/protocol/ConsumerRunningInfo.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbnN1bWVyUnVubmluZ0luZm8uY3Bw) | `100% <0%> (+55.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=footer). Last update [b5b3b35...236b088](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #223:
fix(protocol): delete string print in header decode and open test cases.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #223: fix(protocol): delete string print in header decode and open test cases.
URL: https://github.com/apache/rocketmq-client-cpp/pull/223#issuecomment-572904617
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b5b3b35f0a047799c4be1e11b8956cf00959f984?src=pr&el=desc) will **increase** coverage by `3.19%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 47.82% 51.01% +3.19%
==========================================
Files 173 173
Lines 10441 10701 +260
==========================================
+ Hits 4993 5459 +466
+ Misses 5448 5242 -206
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [test/src/producer/StringIdMakerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvZHVjZXIvU3RyaW5nSWRNYWtlclRlc3QuY3Bw) | `100% <ø> (ø)` | |
| [test/src/protocol/ConsumerRunningInfoTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29uc3VtZXJSdW5uaW5nSW5mb1Rlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [src/protocol/CommandHeader.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuY3Bw) | `81.4% <100%> (+34.5%)` | :arrow_up: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [test/src/protocol/LockBatchBodyTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvTG9ja0JhdGNoQm9keVRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [src/protocol/MessageQueue.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL01lc3NhZ2VRdWV1ZS5jcHA=) | `86.53% <0%> (+1.92%)` | :arrow_up: |
| [src/consumer/SubscriptionData.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL1N1YnNjcmlwdGlvbkRhdGEuY3Bw) | `43.33% <0%> (+8.33%)` | :arrow_up: |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `70.76% <0%> (+21.56%)` | :arrow_up: |
| [src/protocol/LockBatchBody.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0xvY2tCYXRjaEJvZHkuaA==) | `100% <0%> (+33.33%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=footer). Last update [b5b3b35...2baa1d0](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services