[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #90: [MSHADE-382] - Add property to skip execution

[GitBox <gi...@apache.org>]

rmannibucau commented on pull request #90:
URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-840676516


   @aalmiray 
   
   > I'm afraid I do not understand what's being proposed here. The fact that shade replaces the original artifact by_default is the root of the problem. IMHO that's the wrong thing to do however I'm aware that the current behavior has been like this for, well, since forever, and changing it would be more catastrophic than adding a skip field with a default property name.
   
   Not really, the issue is you have multiple use cases and some are valid (replacing the root artifact because you relocate or want to do a fatjar), others are not (because you want a convenient binary).
   In this last case you add a classifier and it is the case we want to be able to skip.
   Therefore I proposed to not do a "skip" but "skipClassified" toggle which would not skip cases where root artifact is replaced but skip all other cases (artifacts with classifiers).
   Guess it solves concerns of everybody.
   
   @mkarg official way is to find a compromise and not try to force in any direction ;). Discussions are only stucked when people don't want to evolve in any direction which was not the case there AFAIK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org