You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/01 09:14:50 UTC

[GitHub] [spark] Yikun edited a comment on pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

Yikun edited a comment on pull request #32867:
URL: https://github.com/apache/spark/pull/32867#issuecomment-872072514


   The root reason of failed to discover is that the deps of PySpark modules is not installed, so we get the wrong list when we do discover.
   
   I re-propose it in https://github.com/apache/spark/pull/33174 , the mainly changed:
   - Add the error check for discover to make sure the discover work, that means if the error like this pr happend would be raised with exception.
   - Move the discover from `dev/run-tests.py` to `python/run-tests.py`, we don't need to discover python test and install python test deps in other modules.
   - Add doctest to make sure discover work as expected.
   
   Thank you for your patience. I will fight this test discover to the end to make up for my mistake. : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org