You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2024/10/28 13:56:08 UTC

[I] Implement `append_n` for `BooleanBuilder` [arrow-rs]

jayzhan211 opened a new issue, #6634:
URL: https://github.com/apache/arrow-rs/issues/6634

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   It has potential to improve the speed if we want to append n false
   
   Currently, we can only do `append_slice`.
   
   ```rust
       #[inline]
       pub fn append_slice(&mut self, v: &[bool]) {
           self.values_builder.append_slice(v);
           self.null_buffer_builder.append_n_non_nulls(v.len());
       }
   ```
   
   If we want to append n false, the first line code can be ignored, since it only appends value if it is true
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   Could be helpful for https://github.com/apache/datafusion/pull/13134
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Implement `append_n` for `BooleanBuilder` [arrow-rs]

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan closed issue #6634: Implement `append_n` for `BooleanBuilder`
URL: https://github.com/apache/arrow-rs/issues/6634


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Implement `append_n` for `BooleanBuilder` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6634:
URL: https://github.com/apache/arrow-rs/issues/6634#issuecomment-2480597219

   `label_issue.py` automatically added labels {'arrow'} from #6646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org