You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/06/18 20:50:32 UTC
[PR] [physical-plan]: remove deprecated spill_record_batch_by_size [datafusion]
alamb opened a new pull request, #23029:
URL: https://github.com/apache/datafusion/pull/23029
## Which issue does this PR close?
- N/A.
## Rationale for this change
`datafusion_physical_plan::spill::spill_record_batch_by_size` was deprecated in DataFusion `46.0.0` in favor of `SpillManager::spill_record_batch_by_size`.
The [API health policy deprecation guidelines](https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines) say deprecated methods remain for 6 major versions or 6 months, whichever is longer. This API has exceeded that window, so this removes the deprecated wrapper.
## What changes are included in this PR?
- Removes the deprecated `datafusion_physical_plan::spill::spill_record_batch_by_size` function.
- Removes the now-unused `PathBuf` import from `spill`.
- Adds an upgrade guide note for the removal and replacement API.
## Are these changes tested?
Yes.
- `cargo fmt --all -- --check`
- `cargo check -p datafusion-physical-plan`
- `cargo test -p datafusion-physical-plan spill`
- `cargo clippy --all-targets --all-features -- -D warnings`
## Are there any user-facing changes?
Yes. This removes a public Rust API that was deprecated in DataFusion `46.0.0`. Downstream users should migrate to `datafusion_physical_plan::spill::SpillManager::spill_record_batch_by_size`.
This is an API change and should be labeled `api-change`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [physical-plan]: remove deprecated spill_record_batch_by_size [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #23029:
URL: https://github.com/apache/datafusion/pull/23029#issuecomment-4793083679
Thank you for the review @kosiew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [physical-plan]: remove deprecated spill_record_batch_by_size [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23029:
URL: https://github.com/apache/datafusion/pull/23029#issuecomment-4746052997
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion-physical-plan v54.0.0 (current)
Built [ 35.948s] (current)
Parsing datafusion-physical-plan v54.0.0 (current)
Parsed [ 0.138s] (current)
Building datafusion-physical-plan v54.0.0 (baseline)
Built [ 35.164s] (baseline)
Parsing datafusion-physical-plan v54.0.0 (baseline)
Parsed [ 0.139s] (baseline)
Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch)
Checked [ 0.878s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_missing.ron
Failed in:
function datafusion_physical_plan::spill::spill_record_batch_by_size, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4bfa2adb465669693e476adfe85560e4239d04b5/datafusion/physical-plan/src/spill/mod.rs:255
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 74.232s] datafusion-physical-plan
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [physical-plan]: remove deprecated spill_record_batch_by_size [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #23029:
URL: https://github.com/apache/datafusion/pull/23029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org