You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/06 08:57:39 UTC

[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #19878: Update H2Database to 2.x

linghengqian commented on code in PR #19878:
URL: https://github.com/apache/shardingsphere/pull/19878#discussion_r939504923


##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatementTest.java:
##########
@@ -430,7 +430,7 @@ public void assertAddOnDuplicateKey() throws SQLException {
             preparedStatement.setString(8, status);
             preparedStatement.setString(9, updatedStatus);
             int result = preparedStatement.executeUpdate();
-            assertThat(result, is(2));
+            assertThat(result, is(4));

Review Comment:
   I'm not sure why H2Database 1.x is 2. At least 4 is reasonable according to the processing logic of H2Database 2.x, I don't know what I overlooked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org