You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/10/29 18:47:49 UTC

[GitHub] [incubator-ratis] amaliujia commented on pull request #240: RATIS-1118. Remove DataStreamServerRpc.start()

amaliujia commented on pull request #240:
URL: https://github.com/apache/incubator-ratis/pull/240#issuecomment-718950463


   R @runzhiwang @szetszwo 
   
   Do you think wether this change make senses?
   
   The drawback of the `start()` is people must remember to call it, which seems too error prone when there are many `start()`, e.g. it might be easy to forget start one of the rpc.
   
   Unless there is something must be done before the data stream server start, otherwise I think we can remove the `start()` as well.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org