[GitHub] [solr] tboeghk commented on a change in pull request #99: [SOLR-15377] Do not swallow execption stack traces in IndexFetcher

[GitBox <gi...@apache.org>]

tboeghk commented on a change in pull request #99:
URL: https://github.com/apache/solr/pull/99#discussion_r623818060



##########
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##########
@@ -677,12 +677,12 @@ IndexFetchResult fetchLatestIndex(boolean forceReplication, boolean forceCoreRel
         markReplicationStop();
         return successfulInstall ? IndexFetchResult.INDEX_FETCH_SUCCESS : IndexFetchResult.INDEX_FETCH_FAILURE;
       } catch (ReplicationHandlerException e) {
-        log.error("User aborted Replication");
+        log.error("User aborted Replication", e);
         return new IndexFetchResult(IndexFetchResult.FAILED_BY_EXCEPTION_MESSAGE, false, e);
       } catch (SolrException e) {
         throw e;
       } catch (InterruptedException e) {
-        throw new InterruptedException("Index fetch interrupted");
+        throw new InterruptedException("Index fetch interrupted", e);

Review comment:
       You're absolutely right! Way better fix!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org