You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/26 00:00:02 UTC
Review Request 42753: Allowed `createLabel` to take an optional
"value".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
This better matches the underlying protobuf definition.
Diffs
-----
src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023
src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
Diff: https://reviews.apache.org/r/42753/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42753: Allowed `createLabel` to take an optional
"value".
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 2:18 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
This better matches the underlying protobuf definition.
Diffs (updated)
-----
src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023
src/common/protobuf_utils.cpp e5a8efcaaa8ec0dece1dd70ae658e9d7d19ccb52
Diff: https://reviews.apache.org/r/42753/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42753: Allowed `createLabel` to take an optional
"value".
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117704
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On Jan. 25, 2016, 6 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42753/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 6 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This better matches the underlying protobuf definition.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023
> src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
>
> Diff: https://reviews.apache.org/r/42753/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42753: Allowed `createLabel` to take an optional
"value".
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117767
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On Jan. 25, 2016, 11 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42753/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 11 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This better matches the underlying protobuf definition.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023
> src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
>
> Diff: https://reviews.apache.org/r/42753/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42753: Allowed `createLabel` to take an optional
"value".
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117638
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On Jan. 25, 2016, 11 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42753/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 11 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This better matches the underlying protobuf definition.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023
> src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
>
> Diff: https://reviews.apache.org/r/42753/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42753: Allowed `createLabel` to take an optional
"value".
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117702
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Jan. 25, 2016, 11 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42753/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 11 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This better matches the underlying protobuf definition.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023
> src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104
>
> Diff: https://reviews.apache.org/r/42753/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>