You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/02/28 18:15:54 UTC
Review Request 65842: Changed `os::spawn` to return `Option`
instead of `int`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65842/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
Bugs: MESOS-4549
https://issues.apache.org/jira/browse/MESOS-4549
Repository: mesos
Description
-------
Similar to `os::system`, `os::spawn` returned -1 on error, which is a
valid exit code on Windows. Using the same solution for `os::system`,
now when `os::spawn` fails, `None` will be returned. Otherwise, the
process exit code will be returned.
Diffs
-----
3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360
3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d
3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c
src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
Diff: https://reviews.apache.org/r/65842/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65842: Stout: Changed `os::spawn` to return
`Option` instead of `int`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65842/#review198734
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On March 1, 2018, 1:50 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65842/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 1:50 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Similar to `os::system`, `os::spawn` returned -1 on error, which is a
> valid exit code on Windows. Using the same solution for `os::system`,
> now when `os::spawn` fails, `None` will be returned. Otherwise, the
> process exit code will be returned.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360
> 3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d
> 3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c
>
>
> Diff: https://reviews.apache.org/r/65842/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65842: Stout: Changed `os::spawn` to return
`Option` instead of `int`.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65842/
-----------------------------------------------------------
(Updated March 1, 2018, 9:50 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
Changes
-------
split commit into 2.
Summary (updated)
-----------------
Stout: Changed `os::spawn` to return `Option<int>` instead of `int`.
Bugs: MESOS-4549
https://issues.apache.org/jira/browse/MESOS-4549
Repository: mesos
Description
-------
Similar to `os::system`, `os::spawn` returned -1 on error, which is a
valid exit code on Windows. Using the same solution for `os::system`,
now when `os::spawn` fails, `None` will be returned. Otherwise, the
process exit code will be returned.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360
3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d
3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c
Diff: https://reviews.apache.org/r/65842/diff/2/
Changes: https://reviews.apache.org/r/65842/diff/1-2/
Testing
-------
make check
Thanks,
Akash Gupta
Re: Review Request 65842: Changed `os::spawn` to return `Option`
instead of `int`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65842/#review198424
-----------------------------------------------------------
Ditto, can you split this review per-project?
I _highly_ recommend sticking to WIP commits on Windows and committing on Linux so you can utilize the very helpful hooks. We really should get those working on Windows...
- Andrew Schwartzmeyer
On Feb. 28, 2018, 10:15 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65842/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 10:15 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Similar to `os::system`, `os::spawn` returned -1 on error, which is a
> valid exit code on Windows. Using the same solution for `os::system`,
> now when `os::spawn` fails, `None` will be returned. Otherwise, the
> process exit code will be returned.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360
> 3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d
> 3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c
> src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/65842/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65842: Changed `os::spawn` to return `Option`
instead of `int`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65842/#review198433
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65839, 65840, 65841, 65842]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2018, 6:15 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65842/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 6:15 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Similar to `os::system`, `os::spawn` returned -1 on error, which is a
> valid exit code on Windows. Using the same solution for `os::system`,
> now when `os::spawn` fails, `None` will be returned. Otherwise, the
> process exit code will be returned.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360
> 3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d
> 3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c
> src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/65842/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65842: Changed `os::spawn` to return `Option`
instead of `int`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65842/#review198403
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65839', '65840', '65841', '65842']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65842
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65842/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (125 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1208 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (49 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (88 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2406 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2430 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2563 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2588 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (482668 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65842/logs/mesos-tests-stderr.log):
```
I0228 20:09:13.533985 460 slave.cpp:3879] Shutting down framework cac8df1c-78d2-4a08-9812-815f9f3ebaee-0000
I0228 20:09:13.533985 9548 master.cpp:10258] Updating the state of task d015bdc4-f2fc-4bd2-9d84-3b83d8741674 of framework cac8df1c-78d2-4a08-9812-815f9f3ebaee-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0228 20:09:13.533985 460 slave.cpp:6586] Shutting down executor 'd015bdc4-f2fc-4bd2-9d84-3b83d8741674' of framework cac8df1c-78d2-4a08-9812-815f9f3ebaee-0000 at executor(1)@10.3.1.5:64832
I0228 20:09:13.535985 460 slave.cpp:922] Agent terminating
W0228 20:09:13.535985 460 slave.cpp:3875] Ignoring shutdown framework cac8df1c-78d2-4a08-9812-815f9f3ebaee-0000 becI0228 20:09:12.808979 1212 exec.cpp:162] Version: 1.6.0
I0228 20:09:12.836979 10128 exec.cpp:236] Executor registered on agent cac8df1c-78d2-4a08-9812-815f9f3ebaee-S0
I0228 20:09:12.840981 7856 executor.cpp:176] Received SUBSCRIBED event
I0228 20:09:12.845983 7856 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0228 20:09:12.846983 7856 executor.cpp:176] Received LAUNCH event
I0228 20:09:12.850985 7856 executor.cpp:648] Starting task d015bdc4-f2fc-4bd2-9d84-3b83d8741674
I0228 20:09:12.934008 7856 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0228 20:09:13.494029 7856 executor.cpp:661] Forked command at 7116
I0228 20:09:13.536986 1696 exec.cpp:445] Executor asked to shutdown
I0228 20:09:13.537986 7856 executor.cpp:176] Received SHUTDOWN event
I0228 20:09:13.537986 7856 executor.cpp:758] Shutting down
I0228 20:09:13.537986 7856 executor.cpp:868] Sending SIGTERM to process tree at pid 7ause it is terminating
I0228 20:09:13.536986 9548 master.cpp:10357] Removing task d015bdc4-f2fc-4bd2-9d84-3b83d8741674 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework cac8df1c-78d2-4a08-9812-815f9f3ebaee-0000 on agent cac8df1c-78d2-4a08-9812-815f9f3ebaee-S0 at slave(398)@10.3.1.5:64811 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 20:09:13.540984 7184 containerizer.cpp:2338] Destroying container f57486f2-bc7b-42bb-9cfd-72dbe2dad7b4 in RUNNING state
I0228 20:09:13.540984 7184 containerizer.cpp:2952] Transitioning the state of container f57486f2-bc7b-42bb-9cfd-72dbe2dad7b4 from RUNNING to DESTROYING
I0228 20:09:13.541985 9548 master.cpp:1306] Agent cac8df1c-78d2-4a08-9812-815f9f3ebaee-S0 at slave(398)@10.3.1.5:64811 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0228 20:09:13.541985 7184 launcher.cpp:156] Asked to destroy container f57486f2-bc7b-42bb-9cfd-72dbe2dad7b4
I0228 20:09:13.542986 9548 master.cpp:3276] Disconnecting agent cac8df1c-78d2-4a08-9812-815f9f3ebaee-S0 at slave(398)@10.3.1.5:64811 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 20:09:13.542986 8176 hierarchical.cpp:344] Removed framework cac8df1c-78d2-4a08-9812-815f9f3ebaee-0000
I0228 20:09:13.544013 9548 master.cpp:3295] Deactivating agent cac8df1c-78d2-4a08-9812-815f9f3ebaee-S0 at slave(398)@10.3.1.5:64811 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 20:09:13.544013 2768 hierarchical.cpp:766] Agent cac8df1c-78d2-4a08-9812-815f9f3ebaee-S0 deactivated
I0228 20:09:13.631175 2768 containerizer.cpp:2791] Container f57486f2-bc7b-42bb-9cfd-72dbe2dad7b4 has exited
I0228 20:09:13.663173 888 master.cpp:1149] Master terminating
I0228 20:09:13.665149 3208 hierarchical.cpp:609] Removed agent cac8df1c-78d2-4a08-9812-815f9f3ebaee-S0
I0228 20:09:14.393177 9636 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Feb. 28, 2018, 6:15 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65842/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 6:15 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Similar to `os::system`, `os::spawn` returned -1 on error, which is a
> valid exit code on Windows. Using the same solution for `os::system`,
> now when `os::spawn` fails, `None` will be returned. Otherwise, the
> process exit code will be returned.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360
> 3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d
> 3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c
> src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/65842/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Akash Gupta
>
>