[jira] [Comment Edited] (HADOOP-9845) Update protobuf to 2.5 from 2.4.x

["Alejandro Abdelnur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732102#comment-13732102 ] 

Alejandro Abdelnur edited comment on HADOOP-9845 at 8/7/13 3:39 PM:
--------------------------------------------------------------------

the build is now failing because protoc 2.4.0 sends the version to sdterr while protoc 2.5.0 sends it to stdout. 

As with this patch we are requiring 2.5.0 I think we are good as I don't expect protoc --version will swing back to stderr in future versions.
                
      was (Author: tucu00):
    the build is not failing because protoc 2.4.0 sends the version to sdterr while protoc 2.5.0 sends it to stdout. As with this patch we are requiring 2.5.0 I think we are good as I don't expect protoc --version will swing back to stderr in future versions.
                  
> Update protobuf to 2.5 from 2.4.x
> ---------------------------------
>
>                 Key: HADOOP-9845
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9845
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 2.0.5-alpha
>            Reporter: stack
>            Assignee: Alejandro Abdelnur
>            Priority: Blocker
>             Fix For: 2.1.0-beta
>
>         Attachments: HADOOP-9845.patch, HADOOP-9845.patch
>
>
> protobuf 2.5 is a bit faster with a new Parse to avoid a builder step and a few other goodies that we'd like to take advantage of over in hbase especially now we are all pb all the time.  Unfortunately the protoc generated files are no longer compatible w/ 2.4.1 generated files.  Hadoop uses 2.4.1 pb.  This latter fact makes it so we cannot upgrade until hadoop does.
> This issue suggests hadoop2 move to protobuf 2.5.
> I can do the patch no prob. if there is interest.
> (When we upgraded our build broke with complaints like the below:
> {code}
> java.lang.UnsupportedOperationException: This is supposed to be overridden by subclasses.
> 	at com.google.protobuf.GeneratedMessage.getUnknownFields(GeneratedMessage.java:180)
> 	at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$GetDatanodeReportRequestProto.getSerializedSize(ClientNamenodeProtocolProtos.java:21566)
> 	at com.google.protobuf.AbstractMessageLite.toByteString(AbstractMessageLite.java:49)
> 	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.constructRpcRequest(ProtobufRpcEngine.java:149)
> 	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:193)
> 	at com.sun.proxy.$Proxy14.getDatanodeReport(Unknown Source)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:164)
> 	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:83)
> 	at com.sun.proxy.$Proxy14.getDatanodeReport(Unknown Source)
> 	at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDatanodeReport(ClientNamenodeProtocolTranslatorPB.java:488)
> 	at org.apache.hadoop.hdfs.DFSClient.datanodeReport(DFSClient.java:1887)
> 	at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:1798
> ...
> {code}
> More over in HBASE-8165 if interested.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira