You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2025/07/31 13:49:06 UTC
[PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]
m1a2st opened a new pull request, #20275:
URL: https://github.com/apache/kafka/pull/20275
This method don't throw `ApiException`, thus we should remove from the java doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #20275:
URL: https://github.com/apache/kafka/pull/20275#issuecomment-3152073381
I see the reason for the IDE warning: `ApiException` is not imported.
<img width="1318" height="592" alt="Screenshot from 2025-08-05 03-21-27" src="https://github.com/user-attachments/assets/7b5a8cb2-e1bd-4e43-b312-c01413b26664" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #20275:
URL: https://github.com/apache/kafka/pull/20275#issuecomment-3153136639
@Yunyung, Thanks for the comment! Maybe we can import ApiException to simplify the resolution of this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky merged PR #20275:
URL: https://github.com/apache/kafka/pull/20275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st closed pull request #20275: MINOR: Cleanup RaftClient#upgradeKRaftVersion java document
URL: https://github.com/apache/kafka/pull/20275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup RaftClient#upgradeKRaftVersion java document [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #20275:
URL: https://github.com/apache/kafka/pull/20275#issuecomment-3146136406
The RaftClient#upgradeKRaftVersion does not explicitly declare any exceptions in its signature. While this is legal in Java if only unchecked exceptions are thrown, it is still recommended to document such behavior in the Javadoc. Therefore, we can describe the potential exceptions in the method’s comment body to make the behavior clearer to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org