[PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

["ShivsundarR (via GitHub)" <gi...@apache.org>]

ShivsundarR opened a new pull request, #19294:
URL: https://github.com/apache/kafka/pull/19294

   *What*
   Currently if we received just a control record in the `ShareFetchResponse`, then the currentFetch in `ShareConsumerImpl` would not be updated as the record is ignored. But in the process, we lose the acknowledgment for this control record which is GAP for control records.
   PR fixes this by adding a check to include the pending acknowledgements even when the `ShareFetch` is empty.
   Added a unit test which verifies this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

["ShivsundarR (via GitHub)" <gi...@apache.org>]

ShivsundarR closed pull request #19294: MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty.
URL: https://github.com/apache/kafka/pull/19294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org