[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2158: [Connector-V2] Add Hive sink connector v2

[GitBox <gi...@apache.org>]

CalvinKirs commented on code in PR #2158:
URL: https://github.com/apache/incubator-seatunnel/pull/2158#discussion_r922001208


##########
seatunnel-connectors-v2/connector-hive/pom.xml:
##########
@@ -31,9 +31,9 @@
 
     <dependencies>
         <dependency>
-            <groupId>org.apache.seatunnel</groupId>
-            <artifactId>seatunnel-hive-shade</artifactId>
-            <version>${project.version}</version>
+            <groupId>org.apache.hive</groupId>
+            <artifactId>hive-exec</artifactId>
+            <scope>provided</scope>
         </dependency>

Review Comment:
   If we do, I think it's better to provide the  version requires, as well as reflect in the documentation that users need to provide it themselves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org