[jira] [Commented] (SLING-5726) Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest

["Stefan Seifert (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453083#comment-17453083 ] 

Stefan Seifert commented on SLING-5726:
---------------------------------------

i think this should rather be an improvement ticket than a bug.

the new PR https://github.com/apache/sling-org-apache-sling-models-impl/pull/27 looks fine for me - but at it's a generic extension that not only applies to ResourcePathInjector we probably should change the ticket title + description as well to make this obvious.

> Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest
> ------------------------------------------------------------------------------------------
>
>                 Key: SLING-5726
>                 URL: https://issues.apache.org/jira/browse/SLING-5726
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Impl 1.2.8
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: Models Implementation 1.5.0
>
>         Attachments: SLING-5726.patch
>
>
> Currently both injectors only work correctly on objects being adaptable to a {{ValueMap}}. For {{ValueMapInjector}} this is documented but for {{ResourcePathInjector}} it is not (http://sling.apache.org/documentation/bundles/models.html#available-injectors), although for the latter it does only matter if the path is given through a resource property and not in a static way.
> This should be relaxed that both also work with {{SlingHttpServletRequest}} as that always carries the current resource from which the {{ValueMap}} can be easily retrieved.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)