You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/12/18 17:19:48 UTC
[GitHub] [nifi] adenes opened a new pull request #4736: NIFI-8102 TailFile can skip characters if tailing a file on NFS mount
adenes opened a new pull request #4736:
URL: https://github.com/apache/nifi/pull/4736
- Force the TailFile processor to recreate and reposition the reader
by setting it to null in case of a NulCharacterEncounteredException
- Updated the TestTailFile.testNULContent() to not initialize the
processor when calling the second run()
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4736: NIFI-8102 TailFile can skip characters if tailing a file on NFS mount
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4736:
URL: https://github.com/apache/nifi/pull/4736#discussion_r545996775
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TailFile.java
##########
@@ -799,7 +799,8 @@ public void process(final OutputStream rawOut) throws IOException {
if (abort.get() != null) {
session.remove(flowFile);
- tfo.setState(new TailFileState(tailFile, file, reader, position, timestamp, length, checksum, state.getBuffer()));
+ // store the new position and set the reader to null to reinitialize and reposition it
+ tfo.setState(new TailFileState(tailFile, file, null, positionHolder.get(), timestamp, length, checksum, state.getBuffer()));
Review comment:
We can't just abandon the existing `reader` here, as we need to make sure that it gets closed. Otherwise we'd be leaking a file handle. But I don't think we really want to close and abandon the reader we already have anyway. Since we know where we want the reader to be positioned, we should be able to just use `reader.position(positionHolder.get());` no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] adenes commented on a change in pull request #4736: NIFI-8102 TailFile can skip characters if tailing a file on NFS mount
Posted by GitBox <gi...@apache.org>.
adenes commented on a change in pull request #4736:
URL: https://github.com/apache/nifi/pull/4736#discussion_r546002454
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TailFile.java
##########
@@ -799,7 +799,8 @@ public void process(final OutputStream rawOut) throws IOException {
if (abort.get() != null) {
session.remove(flowFile);
- tfo.setState(new TailFileState(tailFile, file, reader, position, timestamp, length, checksum, state.getBuffer()));
+ // store the new position and set the reader to null to reinitialize and reposition it
+ tfo.setState(new TailFileState(tailFile, file, null, positionHolder.get(), timestamp, length, checksum, state.getBuffer()));
Review comment:
Thanks @markap14 , agree, updated the pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 closed pull request #4736: NIFI-8102 TailFile can skip characters if tailing a file on NFS mount
Posted by GitBox <gi...@apache.org>.
markap14 closed pull request #4736:
URL: https://github.com/apache/nifi/pull/4736
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4736: NIFI-8102 TailFile can skip characters if tailing a file on NFS mount
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4736:
URL: https://github.com/apache/nifi/pull/4736#issuecomment-748275528
Looks like all checked out good, +1 merged to main. Thanks @adenes !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4736: NIFI-8102 TailFile can skip characters if tailing a file on NFS mount
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4736:
URL: https://github.com/apache/nifi/pull/4736#issuecomment-748251351
Thanks @adenes . Changes look good to me. Will wait for the Github Actions to complete and assuming that all is green there i'll go ahead and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org