You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2022/04/01 00:00:40 UTC

[Impala-ASF-CR] IMPALA-11129: Support running KRPC over Unix Domain Socket

Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18369 )

Change subject: IMPALA-11129: Support running KRPC over Unix Domain Socket
......................................................................

IMPALA-11129: Support running KRPC over Unix Domain Socket

This patch make following changes to support running KRPC over UDS.
  - Add a FLAG_rpc_use_unix_domain_socket to enable running KRPC over
    UDS.
  - Add field uds_address in NetworkAddressPB.
    Replace TNetworkAddress with NetworkAddressPB for RPC related
    class variables and APIs.
  - Set UDS address for each daemon as @impala-kprc:<BackendId>
    during initialization.
  - When FLAG_rpc_use_unix_domain_socket is true, the socket of KRPC
    server will be binded to the UDS address of the daemon.
    KRPC Client will connect to KRPC server with the UDS address of
    the server when creating proxy service, which in turn call
    kudu::Socket::Connect() function to connect KRPC server.
  - rpcz Web page show TCP related stats as 'N/A' when using UDS.
  - Add new unit-tests for UDS.

TODO:
  - Advertise BackendId of admissiond in global admission control mode.
  - Show remote address for KRPC inbound connections on rpcz Web page.

Testing:
  - Passed core test with FLAG_rpc_use_unix_domain_socket as fault
    value false.
  - Passed core test with FLAG_rpc_use_unix_domain_socket as true.

Change-Id: I439f5a03eb425c17451bcaa96a154bb0bca17ee7
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
M be/src/rpc/rpc-mgr-kerberized-test.cc
M be/src/rpc/rpc-mgr-test.cc
M be/src/rpc/rpc-mgr-test.h
M be/src/rpc/rpc-mgr.cc
M be/src/rpc/rpc-mgr.h
M be/src/rpc/rpc-mgr.inline.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/query-driver.cc
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/test-env.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/scheduling/admissiond-env.cc
M be/src/scheduling/admissiond-env.h
M be/src/service/client-request-state.cc
M be/src/service/control-service.cc
M be/src/service/control-service.h
M be/src/service/data-stream-service.cc
M be/src/service/data-stream-service.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/testutil/in-process-servers.cc
M be/src/util/container-util.h
M be/src/util/network-util.cc
M be/src/util/network-util.h
M common/protobuf/common.proto
A tests/custom_cluster/test_krpc_socket.py
M tests/custom_cluster/test_restart_services.py
M tests/webserver/test_web_pages.py
M www/rpcz.tmpl
38 files changed, 477 insertions(+), 137 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/18369/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I439f5a03eb425c17451bcaa96a154bb0bca17ee7
Gerrit-Change-Number: 18369
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>