[GitHub] michael-o commented on a change in pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows
URL: https://github.com/apache/maven-scm/pull/30#discussion_r186231262
 
 

 ##########
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
 ##########
 @@ -144,8 +165,11 @@ protected CheckInScmResult executeCheckInCommand( ScmProviderRepository repo, Sc
             {
                 return new CheckInScmResult( null, statusConsumer.getChangedFiles() );
             }
-
-            Commandline clCommit = createCommitCommandLine( repository, fileSet, messageFile );
+            
+            //SCM-714: Workaround for the Windows terminal command limit
+            //
+            Commandline clCommit = createCommitCommandLine( repository, new ScmFileSet( fileSet.getBasedir() ),
 
 Review comment:
   What is the purpose of this change? This affects `-a` to be added, but we did already add untracked changes...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services