Commits on 1.2.x?

[Martijn Dashorst <ma...@gmail.com>]

Why are there commits on 1.2.x *after* the 1.2.5 release has happened?
We wouldn't maintain 1.2.x for things other than showstopper bugs
which need a vote to be held.

Now we have to release 1.2.6!

Martijn

-- 
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org

Re: Commits on 1.2.x?

[Erik van Oosten <e....@chello.nl>]

Hi,

Is there a JIRA issue already?

I released a Wicket app based on a pre-1.2.5 release 2 weeks ago. I 
would like to know whether we need to create an update after 1.2.6 is out.

Regards,
     Erik.


Johan Compagner wrote:
> Yesterday i just fixed the AccessStackPageMap in 1.3 (that is the one 
> used
> in 1.2)
> there is a bug in it that it leaks pages into the session under specific
> circumstances
>
> so maybe a 1.2.6?
>
> johan

-- 
Erik van Oosten
http://day-to-day-stuff.blogspot.com/

Re: Commits on 1.2.x?

[Martijn Dashorst <ma...@gmail.com>]

Tss... Integer.MAX_VALUE is much smaller than Long.MAX_VALUE. It is
already humble. :)

Martijn

On 2/11/07, Eelco Hillenius <ee...@gmail.com> wrote:
> Yes. Someone on IRC reported seeing a leak as well. Bug can't hardly
> get more serious than that. Could you expand a little bit as to when
> that happens?
>
> Btw, another thing we should do for 1.2.6 is set max versions to a
> more humble valued by default.
>
> Eelco
>
> On 2/11/07, Johan Compagner <jc...@gmail.com> wrote:
> > Yesterday i just fixed the AccessStackPageMap in 1.3 (that is the one used
> > in 1.2)
> > there is a bug in it that it leaks pages into the session under specific
> > circumstances
> >
> > so maybe a 1.2.6?
> >
> > johan
> >
> >
> > On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > >
> > > Sure. So we have this release, which is great and let's leave it with
> > > that. We can make a new 1.2.x release in a few months if there is
> > > demand for it and if there are more bugs that have to go into it.
> > > Meanwhile if people run into issues they can find out they were
> > > reported and fixed and build themselves. Those two fixes are
> > > potentially nasty, but as it doesn't seem to touch most of our user
> > > base, I think we can focus on getting on with 1.3 and 2.0.
> > >
> > > Eelco
> > >
> > >
> > > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > > On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > > > > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > > > > What problems are you talking about?
> > > > >
> > > > > The ones Frank reported.
> > > >
> > > > Though for an Apache release very important and a showstopper, they
> > > > are not for a sf.net hosted release. I'd rather spend the time
> > > > building 1.3-beta1 than fixing these issues in 1.2.x
> > > >
> > > > Martijn
> > > > --
> > > > Vote for Wicket at the
> > > http://www.thebeststuffintheworld.com/vote_for/wicket
> > > > Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
> > > > http://wicketframework.org
> > > >
> > >
> >
>


-- 
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org

Re: Commits on 1.2.x?

[Eelco Hillenius <ee...@gmail.com>]

Yes. Someone on IRC reported seeing a leak as well. Bug can't hardly
get more serious than that. Could you expand a little bit as to when
that happens?

Btw, another thing we should do for 1.2.6 is set max versions to a
more humble valued by default.

Eelco

On 2/11/07, Johan Compagner <jc...@gmail.com> wrote:
> Yesterday i just fixed the AccessStackPageMap in 1.3 (that is the one used
> in 1.2)
> there is a bug in it that it leaks pages into the session under specific
> circumstances
>
> so maybe a 1.2.6?
>
> johan
>
>
> On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> >
> > Sure. So we have this release, which is great and let's leave it with
> > that. We can make a new 1.2.x release in a few months if there is
> > demand for it and if there are more bugs that have to go into it.
> > Meanwhile if people run into issues they can find out they were
> > reported and fixed and build themselves. Those two fixes are
> > potentially nasty, but as it doesn't seem to touch most of our user
> > base, I think we can focus on getting on with 1.3 and 2.0.
> >
> > Eelco
> >
> >
> > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > > > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > > > What problems are you talking about?
> > > >
> > > > The ones Frank reported.
> > >
> > > Though for an Apache release very important and a showstopper, they
> > > are not for a sf.net hosted release. I'd rather spend the time
> > > building 1.3-beta1 than fixing these issues in 1.2.x
> > >
> > > Martijn
> > > --
> > > Vote for Wicket at the
> > http://www.thebeststuffintheworld.com/vote_for/wicket
> > > Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
> > > http://wicketframework.org
> > >
> >
>

Re: Commits on 1.2.x?

[Johan Compagner <jc...@gmail.com>]

Yesterday i just fixed the AccessStackPageMap in 1.3 (that is the one used
in 1.2)
there is a bug in it that it leaks pages into the session under specific
circumstances

so maybe a 1.2.6?

johan


On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> Sure. So we have this release, which is great and let's leave it with
> that. We can make a new 1.2.x release in a few months if there is
> demand for it and if there are more bugs that have to go into it.
> Meanwhile if people run into issues they can find out they were
> reported and fixed and build themselves. Those two fixes are
> potentially nasty, but as it doesn't seem to touch most of our user
> base, I think we can focus on getting on with 1.3 and 2.0.
>
> Eelco
>
>
> On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > > What problems are you talking about?
> > >
> > > The ones Frank reported.
> >
> > Though for an Apache release very important and a showstopper, they
> > are not for a sf.net hosted release. I'd rather spend the time
> > building 1.3-beta1 than fixing these issues in 1.2.x
> >
> > Martijn
> > --
> > Vote for Wicket at the
> http://www.thebeststuffintheworld.com/vote_for/wicket
> > Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
> > http://wicketframework.org
> >
>

Re: Commits on 1.2.x?

[Eelco Hillenius <ee...@gmail.com>]

Sure. So we have this release, which is great and let's leave it with
that. We can make a new 1.2.x release in a few months if there is
demand for it and if there are more bugs that have to go into it.
Meanwhile if people run into issues they can find out they were
reported and fixed and build themselves. Those two fixes are
potentially nasty, but as it doesn't seem to touch most of our user
base, I think we can focus on getting on with 1.3 and 2.0.

Eelco


On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > What problems are you talking about?
> >
> > The ones Frank reported.
>
> Though for an Apache release very important and a showstopper, they
> are not for a sf.net hosted release. I'd rather spend the time
> building 1.3-beta1 than fixing these issues in 1.2.x
>
> Martijn
> --
> Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
> Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
> http://wicketframework.org
>

Re: Commits on 1.2.x?

[Martijn Dashorst <ma...@gmail.com>]

On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > What problems are you talking about?
>
> The ones Frank reported.

Though for an Apache release very important and a showstopper, they
are not for a sf.net hosted release. I'd rather spend the time
building 1.3-beta1 than fixing these issues in 1.2.x

Martijn
-- 
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org

Re: Commits on 1.2.x?

[Eelco Hillenius <ee...@gmail.com>]

On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> What problems are you talking about?

The ones Frank reported.

Eelco

Re: Commits on 1.2.x?

[Martijn Dashorst <ma...@gmail.com>]

What problems are you talking about?

Martijn

On 2/10/07, Igor Vaynberg <ig...@gmail.com> wrote:
> at this point lets just rebuild 1.2.5 (since there were problems with it
> anyways?) and call it a day. whats done is done.
>
> -igor
>
>
> On 2/9/07, Eelco Hillenius <ee...@gmail.com> wrote:
> >
> > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > Why are there commits on 1.2.x *after* the 1.2.5 release has happened?
> > > We wouldn't maintain 1.2.x for things other than showstopper bugs
> > > which need a vote to be held.
> >
> > Ugh, I forgot (honestly!) about voting.
> >
> > Re *after* the release... well, I thought you we still doing a dry run.
> >
> > > Now we have to release 1.2.6!
> >
> > Sorry. I'll help with that. Actually issues 260 and 269 are show
> > stoppers in my book. 260 was reported with the remark 'Bumping up
> > priority, because wicket fails to load the Sun JCE provider on the
> > standard Mac OS X JVM, but with the patch it works.' and 260 got me
> > (Teachscape) in big trouble and it took quite a while to figure out
> > why. It won't touch most people, but when it does, it's nasty.
> >
> > Eelco
> >
>


-- 
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org

Re: Commits on 1.2.x?

[Igor Vaynberg <ig...@gmail.com>]

at this point lets just rebuild 1.2.5 (since there were problems with it
anyways?) and call it a day. whats done is done.

-igor


On 2/9/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > Why are there commits on 1.2.x *after* the 1.2.5 release has happened?
> > We wouldn't maintain 1.2.x for things other than showstopper bugs
> > which need a vote to be held.
>
> Ugh, I forgot (honestly!) about voting.
>
> Re *after* the release... well, I thought you we still doing a dry run.
>
> > Now we have to release 1.2.6!
>
> Sorry. I'll help with that. Actually issues 260 and 269 are show
> stoppers in my book. 260 was reported with the remark 'Bumping up
> priority, because wicket fails to load the Sun JCE provider on the
> standard Mac OS X JVM, but with the patch it works.' and 260 got me
> (Teachscape) in big trouble and it took quite a while to figure out
> why. It won't touch most people, but when it does, it's nasty.
>
> Eelco
>

Re: Commits on 1.2.x?

[Igor Vaynberg <ig...@gmail.com>]

what do you mean flag 1.2.5 as non-ok? as far as i am concerned those
changes can go into 1.2.6, but i thought since you havent uploaded the
release you can rebuild it. but since you have already those changes can
wait until 1.2.6. no biggie. there is no reason why we shouldnt have a
1.2.6especially since eelco says those were important bugs - and it
doesnt have
to happen any time soon, for now people interested in those fixes can use
wicket-1.2.x.

-igor


On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
>
> Then why didn't you flag the 1.2.5 as non-ok? I *JUST* fucking
> uploaded the release to sf.net. If this was communicated, then I could
> have just scrapped the distributions, and update them from svn.
>
> I created the release and uploaded them *explicitly* so that people
> would take a look at it, to prevent this kind of stuff to happen.
>
> Martijn
>
> On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > > Why are there commits on 1.2.x *after* the 1.2.5 release has happened?
> > > We wouldn't maintain 1.2.x for things other than showstopper bugs
> > > which need a vote to be held.
> >
> > Ugh, I forgot (honestly!) about voting.
> >
> > Re *after* the release... well, I thought you we still doing a dry run.
> >
> > > Now we have to release 1.2.6!
> >
> > Sorry. I'll help with that. Actually issues 260 and 269 are show
> > stoppers in my book. 260 was reported with the remark 'Bumping up
> > priority, because wicket fails to load the Sun JCE provider on the
> > standard Mac OS X JVM, but with the patch it works.' and 260 got me
> > (Teachscape) in big trouble and it took quite a while to figure out
> > why. It won't touch most people, but when it does, it's nasty.
> >
> > Eelco
> >
>
>
> --
> Vote for Wicket at the
> http://www.thebeststuffintheworld.com/vote_for/wicket
> Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
> http://wicketframework.org
>

Re: Commits on 1.2.x?

[Martijn Dashorst <ma...@gmail.com>]

I'm not angry at you personally, just at the situation.

Martijn

On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > Then why didn't you flag the 1.2.5 as non-ok?
>
> The release was fine, and having bugs worth applying doesn't mean we
> can't make a release. I fixed those bugs today.
>
> > I *JUST* fucking
> > uploaded the release to sf.net. If this was communicated, then I could
> > have just scrapped the distributions, and update them from svn.
> > I created the release and uploaded them *explicitly* so that people
> > would take a look at it, to prevent this kind of stuff to happen.
>
> I'm sorry, ok. Do you have any f*cking idea how much stuff, bug fixes
> and new features, I committed this week. Very sorry about the
> procedural mistake. Turns out I'm human after all.
>
> Eelco
>


-- 
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org

Re: Commits on 1.2.x?

[Eelco Hillenius <ee...@gmail.com>]

On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> Then why didn't you flag the 1.2.5 as non-ok?

The release was fine, and having bugs worth applying doesn't mean we
can't make a release. I fixed those bugs today.

> I *JUST* fucking
> uploaded the release to sf.net. If this was communicated, then I could
> have just scrapped the distributions, and update them from svn.
> I created the release and uploaded them *explicitly* so that people
> would take a look at it, to prevent this kind of stuff to happen.

I'm sorry, ok. Do you have any f*cking idea how much stuff, bug fixes
and new features, I committed this week. Very sorry about the
procedural mistake. Turns out I'm human after all.

Eelco

Re: Commits on 1.2.x?

[Martijn Dashorst <ma...@gmail.com>]

Then why didn't you flag the 1.2.5 as non-ok? I *JUST* fucking
uploaded the release to sf.net. If this was communicated, then I could
have just scrapped the distributions, and update them from svn.

I created the release and uploaded them *explicitly* so that people
would take a look at it, to prevent this kind of stuff to happen.

Martijn

On 2/10/07, Eelco Hillenius <ee...@gmail.com> wrote:
> On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > Why are there commits on 1.2.x *after* the 1.2.5 release has happened?
> > We wouldn't maintain 1.2.x for things other than showstopper bugs
> > which need a vote to be held.
>
> Ugh, I forgot (honestly!) about voting.
>
> Re *after* the release... well, I thought you we still doing a dry run.
>
> > Now we have to release 1.2.6!
>
> Sorry. I'll help with that. Actually issues 260 and 269 are show
> stoppers in my book. 260 was reported with the remark 'Bumping up
> priority, because wicket fails to load the Sun JCE provider on the
> standard Mac OS X JVM, but with the patch it works.' and 260 got me
> (Teachscape) in big trouble and it took quite a while to figure out
> why. It won't touch most people, but when it does, it's nasty.
>
> Eelco
>


-- 
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org

Re: Commits on 1.2.x?

[Eelco Hillenius <ee...@gmail.com>]

On 2/9/07, Martijn Dashorst <ma...@gmail.com> wrote:
> Why are there commits on 1.2.x *after* the 1.2.5 release has happened?
> We wouldn't maintain 1.2.x for things other than showstopper bugs
> which need a vote to be held.

Ugh, I forgot (honestly!) about voting.

Re *after* the release... well, I thought you we still doing a dry run.

> Now we have to release 1.2.6!

Sorry. I'll help with that. Actually issues 260 and 269 are show
stoppers in my book. 260 was reported with the remark 'Bumping up
priority, because wicket fails to load the Sun JCE provider on the
standard Mac OS X JVM, but with the patch it works.' and 260 got me
(Teachscape) in big trouble and it took quite a while to figure out
why. It won't touch most people, but when it does, it's nasty.

Eelco