[GitHub] brodybits opened a new pull request #247: CB 13855 Fix Windows 8.1 crash on cordova-windows@5

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #247: CB 13855 Fix Windows 8.1 crash on cordova-windows@5
URL: https://github.com/apache/cordova-windows/pull/247
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Windows
   
   ### What does this PR do?
   
   CB-13855 (<https://issues.apache.org/jira/browse/CB-13855>): Fix crash of 8.1-win (Windows 8.1) build on cordova-windows@5 in `5.0.x` branch
   
   ### What testing has been done on this change?
   
   Reproduction: Crash was consistently observed on Windows 8.1 build with cordova-windows@5.0.0 (on my Windows 10 development system).
   
   Verification of bug fix: If I would create a test project (`cordova create CB-13855-test2`), add the Windows platform using the following command:
   ```
    cordova platform add https://github.com/brodybits/cordova-windows#CB-13855
   ```
   
   and then run Windows 8.1 x86 or x64 Release build (or Windows 8.1 Debug build) on my Windows 10 development system then the app would start without crashing.
   
   Sanity testing: if I would run Windows Phone 8.1 ARM Debug or Release build on my Windows Mobile (Windows 10 Mobile) test device the app would start up as normal. If I would run Windows 10 x86 or x64 Release Build on my Windows 10 development system, or run Windows 10 ARM Release build on my Windows 10 Mobile device, the app would start up as normal.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database (<https://issues.apache.org/jira/browse/CB-13855>)
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   ~~Added automated test coverage as appropriate for this change.~~ not done for this change
   
   ### Additional notes
   
   I am raising this fix out of general frustration with cordova-windows@5 which would consistently crash on Windows 8.1 build. This issue was fixed on the master branch after multiple tries (PR #232 for CB-12784 (<https://issues.apache.org/jira/browse/CB-12784>) and PR #239 for CB-13175). I had expected a 5.1.0 release to be issued 1-2 weeks ago but just learned that the master branch is now targeted for cordova-windows@6.0.0 (<http://callback.markmail.org/thread/rzfa2zoydyjq6xso>) and cannot be released until a test failure is resolved (<https://github.com/apache/cordova-windows/pull/246#issuecomment-363906445>).
   
   I am raising this fix with the following commits:
   - first mark 5.0.1-dev
   - cherry-pick 2798167 (fix in `cordova-js-src/splashscreen.js`) from #232
   - fix applied manually to `template/www/cordova.js`
   - mark proposed `5.0.1` release
   
   I would definitely understand this to be a very unusual way to issue a bug fix. I manually applied the change to `template/www/cordova.js` since I could not understand how to automate this change in the 5.0.1 branch (not sure if this is possible or not). I will also understand if the cordova-windows team does not want me to mark the proposed `5.0.1` release.
   
   I would be happy to rework this fix if needed to get the new cordova-windows@5 release not crashing on Windows 8.1 build. It has been broken for way too long.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org