You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2008/06/03 15:44:00 UTC

DO NOT REPLY [Bug 45115] [patch] PCL Render extended to support duplexing codes

https://issues.apache.org/bugzilla/show_bug.cgi?id=45115


Jeremias Maerki <je...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Jeremias Maerki <je...@apache.org>  2008-06-03 06:44:00 PST ---
Martin, thanks for the patch. It looks good except for a typo in the docs which
I can easily fix. I wanted to ask: Do you mind if I rename the new extension
attribute to "duplex-mode"? "page-is-duplex", to me, suggests that it takes a
boolean rather than an integer. "duplex-mode" seems clearer to me. WDYT?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: DO NOT REPLY [Bug 45115] [patch] PCL Render extended to support duplexing codes

Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Hehe. No, I can of course do the changes myself. That's part of the free
patch review service. ;-) Thanks for your rapid feedback!

On 03.06.2008 15:53:35 Martin Edge wrote:
> Sounds fine on the name change - do you need me to supply a patch for the typo or just buy a dictionary? :-)
> 
> Thanks 
> Martin
> 
> -----Original Message-----
> From: bugzilla@apache.org [mailto:bugzilla@apache.org] 
> Sent: Tuesday, 3 June 2008 11:44 PM
> To: fop-dev@xmlgraphics.apache.org
> Subject: DO NOT REPLY [Bug 45115] [patch] PCL Render extended to support duplexing codes
> 
> https://issues.apache.org/bugzilla/show_bug.cgi?id=45115
> 
> 
> Jeremias Maerki <je...@apache.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEW                         |ASSIGNED
> 
> 
> 
> 
> --- Comment #1 from Jeremias Maerki <je...@apache.org>  2008-06-03 06:44:00 PST ---
> Martin, thanks for the patch. It looks good except for a typo in the docs which
> I can easily fix. I wanted to ask: Do you mind if I rename the new extension
> attribute to "duplex-mode"? "page-is-duplex", to me, suggests that it takes a
> boolean rather than an integer. "duplex-mode" seems clearer to me. WDYT?
> 
> 
> -- 
> Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> 




Jeremias Maerki


RE: DO NOT REPLY [Bug 45115] [patch] PCL Render extended to support duplexing codes

Posted by Martin Edge <Ma...@asmorphic.net.au>.
Sounds fine on the name change - do you need me to supply a patch for the typo or just buy a dictionary? :-)

Thanks 
Martin

-----Original Message-----
From: bugzilla@apache.org [mailto:bugzilla@apache.org] 
Sent: Tuesday, 3 June 2008 11:44 PM
To: fop-dev@xmlgraphics.apache.org
Subject: DO NOT REPLY [Bug 45115] [patch] PCL Render extended to support duplexing codes

https://issues.apache.org/bugzilla/show_bug.cgi?id=45115


Jeremias Maerki <je...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Jeremias Maerki <je...@apache.org>  2008-06-03 06:44:00 PST ---
Martin, thanks for the patch. It looks good except for a typo in the docs which
I can easily fix. I wanted to ask: Do you mind if I rename the new extension
attribute to "duplex-mode"? "page-is-duplex", to me, suggests that it takes a
boolean rather than an integer. "duplex-mode" seems clearer to me. WDYT?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.