You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by mp...@apache.org on 2016/07/21 01:17:47 UTC
incubator-kudu git commit: KUDU-1492: Show column
encodings/compression on table page in master
Repository: incubator-kudu
Updated Branches:
refs/heads/master 30721c706 -> 83d692304
KUDU-1492: Show column encodings/compression on table page in master
This displays column attributes for the table schema in picture.
If the table schema doesn't specify these attributes,
AUTO_ENCODING or DEFAULT_COMPRESSION are displayed which means
whatever is the current default value attributes in the given
release. E.g., release 0.9.1 has values PLAIN_ENCODING for encoding
and NO_COMPRESSION for compression.
Sample results are posted in JIRA KUDU-1492.
Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8
Reviewed-on: http://gerrit.cloudera.org:8080/3667
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/83d69230
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/83d69230
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/83d69230
Branch: refs/heads/master
Commit: 83d692304a6ecb0d04dcd757ffcceb2a63c61132
Parents: 30721c7
Author: Dinesh Bhat <di...@cloudera.com>
Authored: Mon Jul 18 09:07:07 2016 -0700
Committer: Mike Percy <mp...@apache.org>
Committed: Thu Jul 21 01:17:34 2016 +0000
----------------------------------------------------------------------
src/kudu/server/webui_util.cc | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/83d69230/src/kudu/server/webui_util.cc
----------------------------------------------------------------------
diff --git a/src/kudu/server/webui_util.cc b/src/kudu/server/webui_util.cc
index e698118..82ec833 100644
--- a/src/kudu/server/webui_util.cc
+++ b/src/kudu/server/webui_util.cc
@@ -36,6 +36,7 @@ void HtmlOutputSchemaTable(const Schema& schema,
*output << "<table class='table table-striped'>\n";
*output << " <tr>"
<< "<th>Column</th><th>ID</th><th>Type</th>"
+ << "<th>Encoding</th><th>Compression</th>"
<< "<th>Read default</th><th>Write default</th>"
<< "</tr>\n";
@@ -49,10 +50,16 @@ void HtmlOutputSchemaTable(const Schema& schema,
if (col.has_write_default()) {
write_default = col.Stringify(col.write_default_value());
}
- *output << Substitute("<tr><th>$0</th><td>$1</td><td>$2</td><td>$3</td><td>$4</td></tr>\n",
+ const ColumnStorageAttributes& attrs = col.attributes();
+ const string& encoding = EncodingType_Name(attrs.encoding);
+ const string& compression = CompressionType_Name(attrs.compression);
+ *output << Substitute("<tr><th>$0</th><td>$1</td><td>$2</td><td>$3</td>"
+ "<td>$4</td><td>$5</td><td>$6</td></tr>\n",
EscapeForHtmlToString(col.name()),
schema.column_id(i),
col.TypeToString(),
+ EscapeForHtmlToString(encoding),
+ EscapeForHtmlToString(compression),
EscapeForHtmlToString(read_default),
EscapeForHtmlToString(write_default));
}