You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/29 14:04:52 UTC

[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…

cherrylzhao opened a new pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996
 
 
   when `sharding.transaction.seata.at.enable = false`,  `SeataATShardingTransactionManager` will be disabled, in this way original seata global transaction across services will compatible with shardingsphere since `TransactionalSQLExecutionHook` can transport global txId in multi-threads.
   
   user should pay attention that `@ShardingTransactionType(TransactionType.BASE)` should not been introduced in original seata global transaction across services

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r399906632
 
 

 ##########
 File path: sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
 ##########
 @@ -47,34 +47,56 @@
     
     private final Map<String, DataSource> dataSourceMap = new HashMap<>();
     
-    private final FileConfiguration configuration = new FileConfiguration("seata.conf");
+    private final String applicationId;
+    
+    private final String transactionServiceGroup;
+    
+    private final boolean enableSeataAT;
+    
+    public SeataATShardingTransactionManager() {
+        FileConfiguration configuration = new FileConfiguration("seata.conf");
+        enableSeataAT = configuration.getBoolean("sharding.transaction.seata.at.enable", true);
+        applicationId = configuration.getConfig("client.application.id");
+        transactionServiceGroup = configuration.getConfig("client.transaction.service.group", "default");
+    }
     
     @Override
     public void init(final DatabaseType databaseType, final Collection<ResourceDataSource> resourceDataSources) {
-        initSeataRPCClient();
-        for (ResourceDataSource each : resourceDataSources) {
-            dataSourceMap.put(each.getOriginalName(), new DataSourceProxy(each.getDataSource()));
+        if (enableSeataAT) {
 
 Review comment:
   If turn off this flag, seata client is not initialized and seat-at is disabled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645263
 
 
   ## Pull Request Test Coverage Report for [Build 10690](https://coveralls.io/builds/29690675)
   
   * **20** of **20**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * **153** unchanged lines in **13** files lost coverage.
   * Overall coverage decreased (**-0.09%**) to **57.253%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/EncryptResultDecoratorEngine.java](https://coveralls.io/builds/29690675/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2FEncryptResultDecoratorEngine.java#L55) | 1 | 0% |
   | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/context/EncryptSQLRewriteContextDecorator.java](https://coveralls.io/builds/29690675/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fcontext%2FEncryptSQLRewriteContextDecorator.java#L48) | 1 | 88.89% |
   | [master-slave-core/master-slave-core-route/src/main/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecorator.java](https://coveralls.io/builds/29690675/source?filename=master-slave-core%2Fmaster-slave-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmasterslave%2Froute%2Fengine%2FMasterSlaveRouteDecorator.java#L63) | 1 | 94.44% |
   | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/context/ShadowSQLRewriteContextDecorator.java](https://coveralls.io/builds/29690675/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcontext%2FShadowSQLRewriteContextDecorator.java#L46) | 1 | 0% |
   | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/ShardingResultMergerEngine.java](https://coveralls.io/builds/29690675/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2FShardingResultMergerEngine.java#L50) | 1 | 85.71% |
   | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29690675/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L52) | 1 | 77.78% |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/29690675/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L157) | 1 | 31.58% |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/datasource/EncryptDataSource.java](https://coveralls.io/builds/29690675/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fdatasource%2FEncryptDataSource.java#L36) | 1 | 88.89% |
   | [shardingsphere-underlying/shardingsphere-pluggable/src/main/java/org/apache/shardingsphere/underlying/pluggble/merge/MergeEngine.java](https://coveralls.io/builds/29690675/source?filename=shardingsphere-underlying%2Fshardingsphere-pluggable%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fpluggble%2Fmerge%2FMergeEngine.java#L48) | 16 | 0% |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/29690675/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L130) | 23 | 74.78% |
   <!-- | **Total:** | **153** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29690675/badge)](https://coveralls.io/builds/29690675) |
   | :-- | --: |
   | Change from base [Build 10688](https://coveralls.io/builds/29688405): |  -0.09% |
   | Covered Lines: | 11730 |
   | Relevant Lines: | 20488 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645263
 
 
   ## Pull Request Test Coverage Report for [Build 10689](https://coveralls.io/builds/29690446)
   
   * **20** of **20**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.02%**) to **57.357%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29690446/badge)](https://coveralls.io/builds/29690446) |
   | :-- | --: |
   | Change from base [Build 10688](https://coveralls.io/builds/29688405): |  0.02% |
   | Covered Lines: | 11745 |
   | Relevant Lines: | 20477 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r399905912
 
 

 ##########
 File path: sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
 ##########
 @@ -47,34 +47,56 @@
     
     private final Map<String, DataSource> dataSourceMap = new HashMap<>();
     
-    private final FileConfiguration configuration = new FileConfiguration("seata.conf");
+    private final String applicationId;
+    
+    private final String transactionServiceGroup;
+    
+    private final boolean enableSeataAT;
+    
+    public SeataATShardingTransactionManager() {
+        FileConfiguration configuration = new FileConfiguration("seata.conf");
+        enableSeataAT = configuration.getBoolean("sharding.transaction.seata.at.enable", true);
 
 Review comment:
   Constant for literal？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r399997169
 
 

 ##########
 File path: sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
 ##########
 @@ -47,34 +47,56 @@
     
     private final Map<String, DataSource> dataSourceMap = new HashMap<>();
     
-    private final FileConfiguration configuration = new FileConfiguration("seata.conf");
+    private final String applicationId;
+    
+    private final String transactionServiceGroup;
+    
+    private final boolean enableSeataAT;
+    
+    public SeataATShardingTransactionManager() {
+        FileConfiguration configuration = new FileConfiguration("seata.conf");
+        enableSeataAT = configuration.getBoolean("sharding.transaction.seata.at.enable", true);
 
 Review comment:
   I'll fix it in next PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645136
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=h1) Report
   > Merging [#4996](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/74c4e287e0175f3ac413c3a977ff939e47ef6356&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `95.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4996      +/-   ##
   ============================================
   + Coverage     53.85%   53.86%   +0.01%     
     Complexity      442      442              
   ============================================
     Files          1145     1145              
     Lines         20469    20477       +8     
     Branches       3745     3746       +1     
   ============================================
   + Hits          11023    11030       +7     
     Misses         8744     8744              
   - Partials        702      703       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...se/seata/at/SeataATShardingTransactionManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctdHJhbnNhY3Rpb24vc2hhcmRpbmctdHJhbnNhY3Rpb24tYmFzZS9zaGFyZGluZy10cmFuc2FjdGlvbi1iYXNlLXNlYXRhLWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFuc2FjdGlvbi9iYXNlL3NlYXRhL2F0L1NlYXRhQVRTaGFyZGluZ1RyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `95.74% <95.00%> (-1.70%)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=footer). Last update [74c4e28...ac36182](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r399998477
 
 

 ##########
 File path: sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
 ##########
 @@ -47,34 +47,56 @@
     
     private final Map<String, DataSource> dataSourceMap = new HashMap<>();
     
-    private final FileConfiguration configuration = new FileConfiguration("seata.conf");
+    private final String applicationId;
+    
+    private final String transactionServiceGroup;
+    
+    private final boolean enableSeataAT;
+    
+    public SeataATShardingTransactionManager() {
+        FileConfiguration configuration = new FileConfiguration("seata.conf");
+        enableSeataAT = configuration.getBoolean("sharding.transaction.seata.at.enable", true);
+        applicationId = configuration.getConfig("client.application.id");
+        transactionServiceGroup = configuration.getConfig("client.transaction.service.group", "default");
+    }
     
     @Override
     public void init(final DatabaseType databaseType, final Collection<ResourceDataSource> resourceDataSources) {
-        initSeataRPCClient();
-        for (ResourceDataSource each : resourceDataSources) {
-            dataSourceMap.put(each.getOriginalName(), new DataSourceProxy(each.getDataSource()));
+        if (enableSeataAT) {
 
 Review comment:
   yes it is，meantime physical datasource will not be wrapped to seata DataSourceProxy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645136
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=h1) Report
   > Merging [#4996](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/74c4e287e0175f3ac413c3a977ff939e47ef6356&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `95.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4996      +/-   ##
   ============================================
   - Coverage     53.85%   53.77%   -0.08%     
     Complexity      442      442              
   ============================================
     Files          1145     1143       -2     
     Lines         20469    20488      +19     
     Branches       3745     3749       +4     
   ============================================
   - Hits          11023    11017       -6     
   - Misses         8744     8770      +26     
   + Partials        702      701       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...se/seata/at/SeataATShardingTransactionManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctdHJhbnNhY3Rpb24vc2hhcmRpbmctdHJhbnNhY3Rpb24tYmFzZS9zaGFyZGluZy10cmFuc2FjdGlvbi1iYXNlLXNlYXRhLWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFuc2FjdGlvbi9iYXNlL3NlYXRhL2F0L1NlYXRhQVRTaGFyZGluZ1RyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `95.74% <95.00%> (-1.70%)` | `0.00 <0.00> (ø)` | |
   | [...ere/sharding/merge/ShardingResultMergerEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9TaGFyZGluZ1Jlc3VsdE1lcmdlckVuZ2luZS5qYXZh) | `85.71% <0.00%> (-14.29%)` | `0.00% <0.00%> (ø%)` | |
   | [...ite/context/EncryptSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29udGV4dC9FbmNyeXB0U1FMUmV3cml0ZUNvbnRleHREZWNvcmF0b3IuamF2YQ==) | `88.88% <0.00%> (-11.12%)` | `0.00% <0.00%> (ø%)` | |
   | [...te/context/ShardingSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvY29udGV4dC9TaGFyZGluZ1NRTFJld3JpdGVDb250ZXh0RGVjb3JhdG9yLmphdmE=) | `77.77% <0.00%> (-9.73%)` | `1.00% <0.00%> (ø%)` | |
   | [...jdbc/core/statement/ShardingPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `71.30% <0.00%> (-8.70%)` | `0.00% <0.00%> (ø%)` | |
   | [...ingjdbc/jdbc/core/statement/ShardingStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3RhdGVtZW50LmphdmE=) | `53.00% <0.00%> (-8.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...rslave/route/engine/MasterSlaveRouteDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-bWFzdGVyLXNsYXZlLWNvcmUvbWFzdGVyLXNsYXZlLWNvcmUtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL3JvdXRlL2VuZ2luZS9NYXN0ZXJTbGF2ZVJvdXRlRGVjb3JhdG9yLmphdmE=) | `94.44% <0.00%> (-5.56%)` | `0.00% <0.00%> (ø%)` | |
   | [...gjdbc/jdbc/core/datasource/ShardingDataSource.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ0RhdGFTb3VyY2UuamF2YQ==) | `92.85% <0.00%> (-1.27%)` | `0.00% <0.00%> (ø%)` | |
   | [.../sharding/route/engine/ShardingRouteDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvU2hhcmRpbmdSb3V0ZURlY29yYXRvci5qYXZh) | `22.80% <0.00%> (-0.41%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [10 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=footer). Last update [74c4e28...ac36182](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services