You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/10 06:16:49 UTC
[GitHub] [dolphinscheduler] luoxiqiang opened a new issue, #11388: [Improvement][Module Name] Improvement title
luoxiqiang opened a new issue, #11388:
URL: https://github.com/apache/dolphinscheduler/issues/11388
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
**I think we should check to see if there are identical events that are unique in the queue before adding events. In some cases, repeating a completed event may raise an exception**
**WorkflowExecuteRunnable.java**
**In addition, I think we should use poll() instead of peek() for fetch events, and add exception events to the end of the queue if they need to be processed repeatedly, otherwise they will always block processing of other events in the queue**
**WorkflowExecuteRunnable.java**
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11388: [Improvement][Master] Events to improve
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11388:
URL: https://github.com/apache/dolphinscheduler/issues/11388#issuecomment-1275436435
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11388: [Improvement][Module Name] Improvement title
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11388:
URL: https://github.com/apache/dolphinscheduler/issues/11388#issuecomment-1210210002
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #11388: [Improvement][Master] Events to improve
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #11388:
URL: https://github.com/apache/dolphinscheduler/issues/11388#issuecomment-1226673520
Could you please provide the exception detail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #11388: [Improvement][Master] Events to improve
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #11388:
URL: https://github.com/apache/dolphinscheduler/issues/11388#issuecomment-1225778658
Can you provide the steps to reproduce this issue? @luoxiqiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] luoxiqiang commented on issue #11388: [Improvement][Master] Events to improve
Posted by GitBox <gi...@apache.org>.
luoxiqiang commented on issue #11388:
URL: https://github.com/apache/dolphinscheduler/issues/11388#issuecomment-1228084094
The StateWheelExecuteThread::checkTask4State method pushes events through the event queue and continues to push events when the same event has not been processed. For example, TaskStateEvent, The following exception is thrown if the task has completed but multiple identical TaskStateEvent events have not yet been handled
Earlier, here is the exception thrown StateEventHandleException, thus blocking the queue event handling, but now modified into StateEventHandleError discarded directly after the incident, although exceptions will be thrown also, but not influence the results, the optimization Suggestions can be ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #11388: [Improvement][Master] Events to improve
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #11388: [Improvement][Master] Events to improve
URL: https://github.com/apache/dolphinscheduler/issues/11388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org