[GitHub] [maven-compiler-plugin] olamy commented on a change in pull request #101: [MCOMPILER-347] Set Xcludes in config passed to actual compiler

[GitBox <gi...@apache.org>]

olamy commented on a change in pull request #101:
URL: https://github.com/apache/maven-compiler-plugin/pull/101#discussion_r825289285



##########
File path: src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java
##########
@@ -203,6 +203,18 @@ public void execute()
         }
     }
 
+    @Override
+    final Set<String> getIncludes()

Review comment:
       the usual pattern in the class is to make this open with `protected` and not `final` 

##########
File path: src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java
##########
@@ -497,4 +497,16 @@ protected boolean isTestCompile()
         return true;
     }
 
+    @Override
+    final Set<String> getIncludes()

Review comment:
       same `protected` and not `final`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org