You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/01/29 15:20:31 UTC
[GitHub] dmitrievanthony commented on a change in pull request #5961:
IGNITE-11222
dmitrievanthony commented on a change in pull request #5961: IGNITE-11222
URL: https://github.com/apache/ignite/pull/5961#discussion_r251877869
##########
File path: modules/ml/src/main/java/org/apache/ignite/ml/naivebayes/discrete/DiscreteNaiveBayesTrainer.java
##########
@@ -116,58 +116,58 @@
}
return res;
})) {
- DiscreteNaiveBayesSumsHolder sumsHolder = dataset.compute(t -> t, (a, b) -> {
- if (a == null)
- return b == null ? new DiscreteNaiveBayesSumsHolder() : b;
- if (b == null)
- return a;
- return a.merge(b);
- });
-
- if (mdl != null && isUpdateable(mdl)) {
- if (checkSumsHolder(sumsHolder, mdl.getSumsHolder()))
- sumsHolder = sumsHolder.merge(mdl.getSumsHolder());
- }
-
- List<Double> sortedLabels = new ArrayList<>(sumsHolder.featureCountersPerLbl.keySet());
- sortedLabels.sort(Double::compareTo);
- assert !sortedLabels.isEmpty() : "The dataset should contain at least one feature";
+ DiscreteNaiveBayesSumsHolder sumsHolder = dataset.compute(t -> t, (a, b) -> {
Review comment:
I don't understand what have you changed here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services