You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/12/13 07:16:25 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2916: HDDS-6079. Replace Freon RK with OCKG/OCKV in acceptance tests
adoroszlai opened a new pull request #2916:
URL: https://github.com/apache/ozone/pull/2916
## What changes were proposed in this pull request?
Replace usage of Freon `randomkeys` with the improved separate subcommands (`ockg` for generating data, `ockv` for verification) in acceptance tests. This makes it easier to remove `RandomKeyGenerator` in the future, and hopefully increases test stability a bit.
Define Robot keywords for Freon tests for reusability.
https://issues.apache.org/jira/browse/HDDS-6079
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/actions/runs/1560480804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2916: HDDS-6079. Replace Freon RK with OCKG/OCKV in acceptance tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2916:
URL: https://github.com/apache/ozone/pull/2916#issuecomment-1072949443
Thanks @fapifta and @smengcl for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2916: HDDS-6079. Replace Freon RK with OCKG/OCKV in acceptance tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2916:
URL: https://github.com/apache/ozone/pull/2916#issuecomment-1024114975
Thanks @fapifta for the review.
> If it works, then why we do not enable it somewhere?
I don't remember the reason. Enabled now in the regular `ozone` environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2916: HDDS-6079. Replace Freon RK with OCKG/OCKV in acceptance tests
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2916:
URL: https://github.com/apache/ozone/pull/2916#discussion_r830389207
##########
File path: hadoop-ozone/dist/src/main/smoketest/auditparser/auditparser.robot
##########
@@ -48,7 +50,7 @@ Testing audit parser
Should Contain ${result} ${user}
${result} = Execute ozone auditparser "${auditworkdir}/audit.db" query "select count(*) from audit where op='CREATE_VOLUME' and RESULT='SUCCESS'"
${result} = Convert To Number ${result}
- Should be true ${result}>${count}
+ Should be true ${result}>=1
Review comment:
This is because we are no longer creating 5 volumes right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2916: HDDS-6079. Replace Freon RK with OCKG/OCKV in acceptance tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2916:
URL: https://github.com/apache/ozone/pull/2916#discussion_r830445063
##########
File path: hadoop-ozone/dist/src/main/smoketest/auditparser/auditparser.robot
##########
@@ -48,7 +50,7 @@ Testing audit parser
Should Contain ${result} ${user}
${result} = Execute ozone auditparser "${auditworkdir}/audit.db" query "select count(*) from audit where op='CREATE_VOLUME' and RESULT='SUCCESS'"
${result} = Convert To Number ${result}
- Should be true ${result}>${count}
+ Should be true ${result}>=1
Review comment:
Yes, `ombg` and `ockg` only create one volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2916: HDDS-6079. Replace Freon RK with OCKG/OCKV in acceptance tests
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2916:
URL: https://github.com/apache/ozone/pull/2916#issuecomment-1050196220
@fapifta can you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2916: HDDS-6079. Replace Freon RK with OCKG/OCKV in acceptance tests
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2916:
URL: https://github.com/apache/ozone/pull/2916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org