You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/10/10 11:18:23 UTC
[PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Mryange opened a new pull request, #68886:
URL: https://github.com/apache/doris/pull/68886
### What problem does this PR solve?
Issue Number: N/A
Related PR: #68332
Problem Summary:
Debug NULL-payload injection exposed query failures in `format_round`, array construction, and mixed TIMESTAMP_NS/TIMESTAMPTZ comparisons. Root cause: these functions consumed the arbitrary nested values of NULL rows and performed range validation before NULL semantics were applied.
Enable the existing NULL-payload default replacement for `format_round`. For `array_with_constant` and `array_repeat`, check the length null map before reading the payload, preserving the existing empty-array result for NULL lengths. For mixed temporal comparisons, compare CCTZ local civil fields directly without rejecting NULL payloads or copying nullable input columns; retain signed years across date boundaries and nanosecond comparison precision.
This PR contains only the three function fixes, based on master. It does not include the debug injection changes from #68332.
### Release note
Fix query errors caused by arbitrary NULL-row payloads in formatting, array construction, and mixed temporal comparisons.
### Check List (For Author)
- Test
- [x] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
Before migration to master, the identical patch was validated on the NULL-payload injection branch: ASAN BE build and changed-line clang-tidy passed. Six suites passed: `test_format_round_decimal`, `test_format_round_decimal256`, `fix_array_type_and_lambda_func`, `test_timestamp_ns_mixed_datetime_expressions`, `test_array_functions_array_with_const`, and `nereids_scalar_fn_Array`. Supplemental SQL checked mixed temporal `nullif`, NULL-safe equality, NULL inputs, and empty arrays for NULL lengths. `test_pythonudf_module_advanced` was attempted but blocked by disabled Python UDF support. No BE unit tests were run. After migration, clang-format 16, header hygiene, and `git diff --check` passed; the master-based branch was not rebuilt.
- Behavior changed:
- [ ] No.
- [x] Yes. NULL-row payloads no longer trigger these validation errors; mixed temporal comparisons can compare local civil dates outside the DATETIMEV2 range.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6110980864
<details>
<summary>TPC-DS: <b>Total hot run time: 151640 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 823abe9b41c4db2a3f8163057a443dd25a8f800b, data reload: false
query5 4306 575 451 451
query6 421 204 197 197
query7 4809 448 220 220
query8 321 184 158 158
query9 8759 3988 3978 3978
query10 455 320 262 262
query11 6044 3404 3202 3202
query12 148 92 85 85
query13 1250 428 315 315
query14 6530 4759 4479 4479
query14_1 4243 4174 4251 4174
query15 208 197 182 182
query16 945 446 344 344
query17 873 658 542 542
query18 2407 444 309 309
query19 199 163 134 134
query20 82 81 79 79
query21 212 133 112 112
query22 13026 13002 12856 12856
query23 12996 12547 12174 12174
query23_1 12172 12432 12493 12432
query24 7093 832 444 444
query24_1 456 456 450 450
query25 504 390 364 364
query26 1250 249 131 131
query27 2792 428 262 262
query28 4665 1908 1895 1895
query29 1538 564 437 437
query30 294 213 185 185
query31 877 754 643 643
query32 147 91 87 87
query33 535 296 232 232
query34 992 852 491 491
query35 759 783 648 648
query36 853 795 729 729
query37 131 97 86 86
query38 1788 1713 1704 1704
query39 705 696 708 696
query39_1 645 643 682 643
query40 222 116 89 89
query41 65 62 62 62
query42 85 83 91 83
query43 358 383 328 328
query44 1277 674 676 674
query45 189 179 167 167
query46 819 957 558 558
query47 3006 2922 2956 2922
query48 286 301 212 212
query49 572 391 285 285
query50 656 269 212 212
query51 10364 10080 10392 10080
query52 79 79 69 69
query53 184 204 151 151
query54 236 192 172 172
query55 74 74 60 60
query56 222 213 216 213
query57 1602 1545 1570 1545
query58 276 266 246 246
query59 2353 2379 2111 2111
query60 278 236 231 231
query61 144 154 145 145
query62 384 340 288 288
query63 205 164 167 164
query64 2742 938 843 843
query65 3413 3387 3373 3373
query66 1795 451 318 318
query67 20208 20223 19966 19966
query68 2904 981 605 605
query69 418 303 252 252
query70 921 859 823 823
query71 310 234 218 218
query72 2790 2660 2394 2394
query73 507 513 287 287
query74 4568 4497 4308 4308
query75 2315 2288 1919 1919
query76 2285 1000 586 586
query77 353 395 298 298
query78 9005 8951 8435 8435
query79 994 835 517 517
query80 1247 410 334 334
query81 590 326 280 280
query82 584 136 107 107
query83 296 202 182 182
query84 316 123 103 103
query85 898 426 353 353
query86 403 236 227 227
query87 2000 1939 1843 1843
query88 3569 2660 2643 2643
query89 343 284 257 257
query90 1908 177 179 177
query91 159 156 143 143
query92 98 83 86 83
query93 989 1003 561 561
query94 658 297 303 297
query95 589 425 341 341
query96 664 509 234 234
query97 2451 2447 2336 2336
query98 155 145 142 142
query99 770 762 649 649
Total cold run time: 234286 ms
Total hot run time: 151640 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6110627794
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6107190490
<details>
<summary>TPC-DS: <b>Total hot run time: 151948 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 823abe9b41c4db2a3f8163057a443dd25a8f800b, data reload: false
query5 4307 567 449 449
query6 426 202 187 187
query7 4799 449 219 219
query8 319 184 168 168
query9 8773 4038 4036 4036
query10 467 316 257 257
query11 5923 3420 3198 3198
query12 139 91 84 84
query13 1283 441 365 365
query14 6554 4795 4507 4507
query14_1 4282 4274 4281 4274
query15 208 206 195 195
query16 945 418 414 414
query17 862 667 537 537
query18 2426 430 309 309
query19 204 165 144 144
query20 82 80 77 77
query21 223 140 115 115
query22 13082 13021 12793 12793
query23 13112 12559 12177 12177
query23_1 12289 12149 12301 12149
query24 7121 830 458 458
query24_1 460 467 461 461
query25 513 389 343 343
query26 1263 249 135 135
query27 2776 430 266 266
query28 4627 1908 1897 1897
query29 1534 584 443 443
query30 299 217 181 181
query31 887 755 644 644
query32 139 91 88 88
query33 494 301 232 232
query34 900 853 507 507
query35 744 765 646 646
query36 821 797 737 737
query37 134 101 93 93
query38 1827 1779 1676 1676
query39 727 727 720 720
query39_1 709 697 682 682
query40 216 112 102 102
query41 66 71 64 64
query42 83 82 84 82
query43 372 379 324 324
query44 1357 688 692 688
query45 172 172 164 164
query46 841 958 572 572
query47 3001 3001 2964 2964
query48 327 312 213 213
query49 568 394 290 290
query50 708 284 214 214
query51 10167 10164 10034 10034
query52 77 77 69 69
query53 189 208 155 155
query54 245 198 193 193
query55 76 70 64 64
query56 242 217 199 199
query57 1616 1570 1572 1570
query58 279 254 254 254
query59 2350 2370 2159 2159
query60 279 237 220 220
query61 144 148 145 145
query62 385 343 285 285
query63 202 169 170 169
query64 2728 912 757 757
query65 3449 3378 3379 3378
query66 1779 417 305 305
query67 20272 20205 20303 20205
query68 2934 999 598 598
query69 381 290 250 250
query70 926 854 816 816
query71 307 230 202 202
query72 2808 2498 2307 2307
query73 531 539 295 295
query74 4599 4457 4291 4291
query75 2327 2294 1899 1899
query76 2305 1032 628 628
query77 374 446 306 306
query78 8850 8903 8507 8507
query79 877 852 518 518
query80 477 424 363 363
query81 511 320 272 272
query82 213 137 112 112
query83 204 195 179 179
query84 282 120 100 100
query85 753 413 376 376
query86 253 237 238 237
query87 2010 1948 1831 1831
query88 3600 2687 2670 2670
query89 327 295 257 257
query90 2081 182 185 182
query91 164 147 123 123
query92 97 86 78 78
query93 1006 1010 562 562
query94 450 300 278 278
query95 584 341 373 341
query96 683 533 241 241
query97 2435 2408 2322 2322
query98 157 157 140 140
query99 774 764 647 647
Total cold run time: 232901 ms
Total hot run time: 151948 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6097497886
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6111027363
<details>
<summary>ClickBench: <b>Total hot run time: 24.48 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 823abe9b41c4db2a3f8163057a443dd25a8f800b, data reload: false
query1 0.01 0.01 0.01
query2 0.10 0.04 0.04
query3 0.26 0.11 0.11
query4 1.61 0.12 0.13
query5 0.27 0.24 0.24
query6 1.18 0.68 0.68
query7 0.04 0.01 0.01
query8 0.06 0.04 0.03
query9 0.42 0.34 0.34
query10 0.60 0.56 0.58
query11 0.21 0.14 0.14
query12 0.19 0.14 0.15
query13 0.49 0.50 0.51
query14 0.98 0.94 0.96
query15 0.64 0.61 0.61
query16 0.36 0.34 0.34
query17 1.08 1.11 1.07
query18 0.23 0.21 0.24
query19 2.07 2.02 2.03
query20 0.02 0.02 0.01
query21 15.42 0.29 0.14
query22 4.41 0.06 0.05
query23 16.29 0.33 0.13
query24 2.78 0.61 0.42
query25 0.11 0.05 0.05
query26 1.08 0.25 0.15
query27 0.06 0.03 0.03
query28 1.69 0.60 0.38
query29 12.54 4.13 3.31
query30 0.29 0.15 0.14
query31 2.77 0.57 0.34
query32 3.25 0.62 0.51
query33 3.20 3.24 3.33
query34 15.39 4.00 3.36
query35 3.34 3.31 3.30
query36 0.58 0.47 0.47
query37 0.09 0.07 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.18 0.15 0.14
query41 0.08 0.03 0.03
query42 0.04 0.03 0.02
query43 0.05 0.03 0.03
Total cold run time: 94.54 s
Total hot run time: 24.48 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6097772627
<details>
<summary>ClickBench: <b>Total hot run time: 24.53 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 50363d7f3bf197b483e2d26f88cacc304ad8aa86, data reload: false
query1 0.00 0.00 0.01
query2 0.11 0.05 0.05
query3 0.27 0.12 0.11
query4 1.61 0.13 0.13
query5 0.29 0.24 0.25
query6 1.17 0.69 0.68
query7 0.05 0.01 0.00
query8 0.05 0.03 0.04
query9 0.43 0.34 0.35
query10 0.61 0.58 0.56
query11 0.21 0.14 0.14
query12 0.19 0.15 0.14
query13 0.49 0.49 0.49
query14 0.99 0.97 0.96
query15 0.63 0.60 0.60
query16 0.33 0.34 0.33
query17 1.13 1.15 1.18
query18 0.23 0.21 0.20
query19 2.05 2.06 2.02
query20 0.02 0.02 0.02
query21 15.52 0.28 0.14
query22 4.48 0.05 0.05
query23 16.22 0.32 0.12
query24 2.88 0.61 0.44
query25 0.10 0.08 0.05
query26 1.54 0.25 0.16
query27 0.05 0.04 0.04
query28 2.04 0.62 0.41
query29 12.51 4.05 3.24
query30 0.28 0.15 0.13
query31 2.78 0.58 0.34
query32 3.22 0.61 0.52
query33 3.14 3.22 3.25
query34 15.43 3.97 3.38
query35 3.35 3.33 3.35
query36 0.55 0.44 0.46
query37 0.10 0.07 0.06
query38 0.06 0.03 0.03
query39 0.04 0.03 0.02
query40 0.19 0.15 0.14
query41 0.08 0.03 0.03
query42 0.04 0.02 0.03
query43 0.04 0.03 0.04
Total cold run time: 95.5 s
Total hot run time: 24.53 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6097648672
<details>
<summary>TPC-H: <b>Total hot run time: 29350 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 50363d7f3bf197b483e2d26f88cacc304ad8aa86, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17587 5685 5657 5657
q2 2152 295 251 251
q3 10209 1414 839 839
q4 4683 477 358 358
q5 7439 802 549 549
q6 190 188 160 160
q7 784 806 601 601
q8 9244 1339 1163 1163
q9 5786 4466 4450 4450
q10 6797 1279 1028 1028
q11 444 263 234 234
q12 630 406 286 286
q13 18059 3067 2389 2389
q14 272 263 245 245
q15 q16 737 732 672 672
q17 1175 761 563 563
q18 7148 6221 6221 6221
q19 1114 973 612 612
q20 396 336 225 225
q21 6050 2614 2560 2560
q22 390 352 287 287
Total cold run time: 101286 ms
Total hot run time: 29350 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6665 6626 6818 6626
q2 771 619 584 584
q3 5662 5722 5253 5253
q4 2066 2164 1557 1557
q5 5704 5556 5605 5556
q6 242 192 154 154
q7 2454 2060 1837 1837
q8 3123 2842 2718 2718
q9 8327 8214 8059 8059
q10 3720 3661 3234 3234
q11 593 401 371 371
q12 666 706 494 494
q13 2747 3100 2372 2372
q14 279 300 259 259
q15 q16 668 666 610 610
q17 7759 7061 6862 6862
q18 13079 12240 13036 12240
q19 910 776 788 776
q20 2186 2165 1951 1951
q21 5786 4878 4786 4786
q22 485 451 400 400
Total cold run time: 73892 ms
Total hot run time: 66699 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6096939034
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6097734404
<details>
<summary>TPC-DS: <b>Total hot run time: 151734 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 50363d7f3bf197b483e2d26f88cacc304ad8aa86, data reload: false
query5 4318 568 453 453
query6 436 206 188 188
query7 4794 432 220 220
query8 316 179 163 163
query9 8748 3933 3917 3917
query10 485 338 309 309
query11 5978 3415 3206 3206
query12 158 89 82 82
query13 1249 450 316 316
query14 6546 4788 4542 4542
query14_1 4228 4244 4202 4202
query15 204 200 180 180
query16 945 430 419 419
query17 872 648 561 561
query18 2404 423 305 305
query19 198 156 133 133
query20 81 79 77 77
query21 207 134 113 113
query22 13087 13096 12871 12871
query23 13317 12581 12287 12287
query23_1 12247 12206 12177 12177
query24 7084 834 459 459
query24_1 467 463 472 463
query25 536 416 363 363
query26 1275 256 135 135
query27 2770 439 274 274
query28 4608 1904 1906 1904
query29 1543 593 455 455
query30 300 218 188 188
query31 862 757 658 658
query32 140 98 92 92
query33 512 313 252 252
query34 912 857 498 498
query35 764 768 669 669
query36 815 820 745 745
query37 124 101 91 91
query38 1791 1736 1697 1697
query39 694 709 657 657
query39_1 662 652 666 652
query40 225 118 98 98
query41 76 70 68 68
query42 90 86 83 83
query43 371 380 323 323
query44 1289 691 690 690
query45 184 177 165 165
query46 847 947 590 590
query47 2882 3025 2915 2915
query48 290 291 211 211
query49 576 391 286 286
query50 676 269 215 215
query51 10457 10141 10515 10141
query52 77 83 69 69
query53 195 207 146 146
query54 233 197 168 168
query55 72 71 60 60
query56 239 224 200 200
query57 1593 1589 1582 1582
query58 284 258 245 245
query59 2348 2378 2155 2155
query60 279 237 223 223
query61 150 148 147 147
query62 401 336 284 284
query63 195 160 162 160
query64 2695 921 780 780
query65 3422 3373 3379 3373
query66 1752 417 293 293
query67 20170 20141 20006 20006
query68 3130 978 597 597
query69 380 298 248 248
query70 917 856 816 816
query71 281 223 206 206
query72 2929 2594 2215 2215
query73 513 517 288 288
query74 4583 4452 4326 4326
query75 2328 2292 1904 1904
query76 2291 1010 586 586
query77 354 411 317 317
query78 9059 8979 8543 8543
query79 962 891 506 506
query80 557 423 334 334
query81 531 327 276 276
query82 572 140 109 109
query83 258 214 173 173
query84 306 114 100 100
query85 810 418 367 367
query86 341 240 234 234
query87 2003 1940 1817 1817
query88 3561 2644 2632 2632
query89 343 300 263 263
query90 1906 177 175 175
query91 163 147 123 123
query92 95 85 89 85
query93 990 965 546 546
query94 442 312 287 287
query95 582 350 379 350
query96 665 509 237 237
query97 2490 2428 2317 2317
query98 157 151 137 137
query99 779 770 661 661
Total cold run time: 233838 ms
Total hot run time: 151734 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6121298754
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6096969471
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6107117695
<details>
<summary>TPC-H: <b>Total hot run time: 29208 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 823abe9b41c4db2a3f8163057a443dd25a8f800b, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17577 5532 5528 5528
q2 2061 304 252 252
q3 10286 1388 830 830
q4 4668 482 351 351
q5 7435 814 541 541
q6 193 189 160 160
q7 766 812 629 629
q8 9260 1289 1150 1150
q9 5754 4455 4444 4444
q10 6834 1281 1023 1023
q11 424 251 254 251
q12 632 405 284 284
q13 18043 3045 2403 2403
q14 274 281 255 255
q15 q16 725 728 670 670
q17 1171 730 562 562
q18 7043 6208 6165 6165
q19 1113 968 604 604
q20 401 337 236 236
q21 5559 2579 2623 2579
q22 410 360 291 291
Total cold run time: 100629 ms
Total hot run time: 29208 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6490 6487 6473 6473
q2 702 588 593 588
q3 5543 5674 5226 5226
q4 2072 2181 1650 1650
q5 5983 5704 5629 5629
q6 256 196 153 153
q7 2294 1993 1923 1923
q8 3144 2777 2722 2722
q9 8290 8149 7668 7668
q10 3641 3591 3218 3218
q11 613 433 405 405
q12 665 692 505 505
q13 2770 3062 2372 2372
q14 284 288 260 260
q15 q16 680 690 609 609
q17 7842 7085 6952 6952
q18 13122 12270 12946 12270
q19 923 792 795 792
q20 2211 2153 1957 1957
q21 6000 4883 4957 4883
q22 515 457 410 410
Total cold run time: 74040 ms
Total hot run time: 66665 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6107226530
<details>
<summary>ClickBench: <b>Total hot run time: 24.38 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 823abe9b41c4db2a3f8163057a443dd25a8f800b, data reload: false
query1 0.01 0.01 0.00
query2 0.09 0.05 0.04
query3 0.27 0.11 0.12
query4 1.61 0.12 0.14
query5 0.25 0.25 0.25
query6 1.17 0.69 0.68
query7 0.04 0.00 0.01
query8 0.05 0.04 0.03
query9 0.43 0.37 0.36
query10 0.62 0.61 0.58
query11 0.20 0.14 0.13
query12 0.18 0.15 0.15
query13 0.49 0.49 0.47
query14 1.00 0.97 0.94
query15 0.62 0.61 0.63
query16 0.35 0.36 0.37
query17 1.12 1.13 1.13
query18 0.22 0.21 0.20
query19 2.14 2.03 1.97
query20 0.02 0.01 0.02
query21 15.50 0.27 0.13
query22 4.50 0.05 0.05
query23 16.26 0.33 0.12
query24 3.25 0.55 0.41
query25 0.10 0.08 0.04
query26 1.11 0.25 0.15
query27 0.05 0.05 0.03
query28 2.10 0.60 0.41
query29 12.52 4.18 3.24
query30 0.28 0.14 0.13
query31 2.78 0.57 0.32
query32 3.22 0.62 0.53
query33 3.14 3.34 3.16
query34 15.63 3.98 3.38
query35 3.36 3.33 3.33
query36 0.56 0.49 0.46
query37 0.10 0.07 0.06
query38 0.05 0.03 0.04
query39 0.03 0.04 0.03
query40 0.17 0.15 0.14
query41 0.09 0.03 0.03
query42 0.03 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 95.75 s
Total hot run time: 24.38 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6110888937
<details>
<summary>TPC-H: <b>Total hot run time: 28962 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 823abe9b41c4db2a3f8163057a443dd25a8f800b, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17593 5636 5507 5507
q2 2153 308 255 255
q3 10217 1371 835 835
q4 4683 471 347 347
q5 7430 797 534 534
q6 188 190 158 158
q7 763 802 603 603
q8 9253 1340 1097 1097
q9 5809 4423 4420 4420
q10 6825 1292 1028 1028
q11 450 262 240 240
q12 629 400 293 293
q13 18038 3012 2376 2376
q14 276 268 247 247
q15 q16 725 721 657 657
q17 1161 740 579 579
q18 6977 6193 6152 6152
q19 1125 958 588 588
q20 380 336 223 223
q21 5247 2541 2647 2541
q22 391 346 282 282
Total cold run time: 100313 ms
Total hot run time: 28962 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6477 6488 6418 6418
q2 696 605 545 545
q3 5608 5707 5217 5217
q4 2337 2130 1592 1592
q5 5909 5550 5625 5550
q6 249 189 149 149
q7 2272 2019 1796 1796
q8 3112 2847 2828 2828
q9 8161 7866 7744 7744
q10 3651 3600 3242 3242
q11 599 436 406 406
q12 667 698 522 522
q13 2742 3071 2368 2368
q14 290 300 277 277
q15 q16 666 691 616 616
q17 7774 7065 6838 6838
q18 13163 12270 13046 12270
q19 889 774 769 769
q20 2198 2168 1958 1958
q21 5809 4794 4821 4794
q22 484 450 413 413
Total cold run time: 73753 ms
Total hot run time: 66312 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6117544684
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #68886:
URL: https://github.com/apache/doris/pull/68886#issuecomment-6106899910
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](function) Avoid validating NULL payloads in scalar functions [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange merged PR #68886:
URL: https://github.com/apache/doris/pull/68886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org