[GitHub] [calcite] tanclary commented on a diff in pull request #3366: [CALCITE-5909] Failed SqlParserTest#testNoUnintendedNewReservedKeywords and not covered by build pipeline

["tanclary (via GitHub)" <gi...@apache.org>]

tanclary commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1301806892


##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
     |   <NTILE>
     |   <NULLIF>
     |   <OCTET_LENGTH>
+    |   <PERCENTILE_CONT>
+    |   <PERCENTILE_DISC>

Review Comment:
   Sorry for the late comment, just to give more context: the parsing for BigQuery's PERCENTILE functions was different from that which Calcite already supported. You are correct in saying that the goal was to extend parsing to work for either form (the main difference is in operand count & presence of `WITHIN GROUP` vs `OVER` clause). It would be great if this addition could be preserved and I am happy to help review/contribute to any necessary refactoring if that's required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org