You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/10/13 10:58:27 UTC
[PR] Default connection and request timeouts of 5 seconds [arrow-rs]
tustvold opened a new pull request, #4928:
URL: https://github.com/apache/arrow-rs/pull/4928
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Infinite timeouts are surprising and can result in workloads hanging with no obvious cause.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Default connection and request timeouts of 5 seconds [arrow-rs]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on code in PR #4928:
URL: https://github.com/apache/arrow-rs/pull/4928#discussion_r1358119975
##########
object_store/src/client/mod.rs:
##########
@@ -188,6 +188,35 @@ pub struct ClientOptions {
http2_only: ConfigValue<bool>,
}
+impl Default for ClientOptions {
+ fn default() -> Self {
+ // Defaults based on
+ // <https://docs.aws.amazon.com/sdkref/latest/guide/feature-smart-config-defaults.html>
+ // <https://docs.aws.amazon.com/whitepapers/latest/s3-optimizing-performance-best-practices/timeouts-and-retries-for-latency-sensitive-applications.html>
+ // Which recommend a connection timeout of 3.1s and a request timeout of 2s
+ Self {
+ user_agent: None,
+ content_type_map: Default::default(),
+ default_content_type: None,
+ default_headers: None,
+ proxy_url: None,
+ proxy_ca_certificate: None,
+ proxy_excludes: None,
+ allow_http: Default::default(),
+ allow_insecure: Default::default(),
+ timeout: Some(Duration::from_secs(5).into()),
Review Comment:
Since there are `with_{connection_}timeout` methods that accepts `Duration` but not `None`, maybe add two new methods `with_infinite_{connection_}timeout` and with clear doc warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Default connection and request timeouts of 5 seconds [arrow-rs]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on code in PR #4928:
URL: https://github.com/apache/arrow-rs/pull/4928#discussion_r1358119975
##########
object_store/src/client/mod.rs:
##########
@@ -188,6 +188,35 @@ pub struct ClientOptions {
http2_only: ConfigValue<bool>,
}
+impl Default for ClientOptions {
+ fn default() -> Self {
+ // Defaults based on
+ // <https://docs.aws.amazon.com/sdkref/latest/guide/feature-smart-config-defaults.html>
+ // <https://docs.aws.amazon.com/whitepapers/latest/s3-optimizing-performance-best-practices/timeouts-and-retries-for-latency-sensitive-applications.html>
+ // Which recommend a connection timeout of 3.1s and a request timeout of 2s
+ Self {
+ user_agent: None,
+ content_type_map: Default::default(),
+ default_content_type: None,
+ default_headers: None,
+ proxy_url: None,
+ proxy_ca_certificate: None,
+ proxy_excludes: None,
+ allow_http: Default::default(),
+ allow_insecure: Default::default(),
+ timeout: Some(Duration::from_secs(5).into()),
Review Comment:
Since there are `with_{connection_}timeout` methods that accepts `Duration` but not `None`, maybe add two new methods `with_infinite_{connection_}timeout` and with clear doc warnings? Otherwise there is no public way to set these options to `None`. If you NEVER want anyone to set this to `None`, then this shouldn't be an `Option`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Default connection and request timeouts of 5 seconds [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4928:
URL: https://github.com/apache/arrow-rs/pull/4928#discussion_r1358111402
##########
object_store/src/client/mod.rs:
##########
@@ -444,7 +473,19 @@ impl ClientOptions {
}
}
- pub(crate) fn client(&self) -> super::Result<Client> {
+ /// Create a [`Client`] with overrides optimised for metadata endpoint access
+ ///
+ /// In particular:
+ /// * Allows HTTP as metadata endpoints do not use TLS
+ /// * Configures a low connection timeout to provide quick feedback if not present
+ pub(crate) fn metadata_client(&self) -> Result<Client> {
+ self.clone()
+ .with_allow_http(true)
+ .with_connect_timeout(Duration::from_secs(1))
Review Comment:
This will help new users who may use the crate without configuring any credentials, which will then default to the metadata credentials, which will then hang indefinitely trying to get credentials from a non-existent metadata endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Default connection and request timeouts of 5 seconds [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4928:
URL: https://github.com/apache/arrow-rs/pull/4928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org