You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/29 00:30:27 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #35996: [SPARK-38680][INFRA] Set upperbound for pandas-stubs in CI
HyukjinKwon opened a new pull request #35996:
URL: https://github.com/apache/spark/pull/35996
### What changes were proposed in this pull request?
`pandas-stubs` released `1.2.0.54` but that seems like havng a breaking change:
e.g., ) https://github.com/apache/spark/runs/5729037000?check_suite_focus=true
```
starting mypy annotations test...
annotations failed mypy checks:
python/pyspark/pandas/ml.py:62: error: Incompatible types in assignment (expression has type "Index", variable has type "MultiIndex") [assignment]
python/pyspark/pandas/frame.py:6133: error: unused "type: ignore" comment
python/pyspark/pandas/frame.py:6292: error: Incompatible types in assignment (expression has type "Index", variable has type "MultiIndex") [assignment]
Found 3 errors in 2 files (checked 325 source files)
```
This PR proposes to pin pandas-stubs version for now to avoid breaking CI.
### Why are the changes needed?
To have the stable CI status.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
It should be tested in this CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35996: [SPARK-38680][INFRA] Set upperbound for pandas-stubs in CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35996:
URL: https://github.com/apache/spark/pull/35996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35996: [SPARK-38680][INFRA] Set upperbound for pandas-stubs in CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35996:
URL: https://github.com/apache/spark/pull/35996#issuecomment-1081324135
Thanks @wangyum.
Merged to master and branch-3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35996: [SPARK-38680][INFRA] Set upperbound for pandas-stubs in CI
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35996:
URL: https://github.com/apache/spark/pull/35996#issuecomment-1081280158
cc @zero323 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #35996: [SPARK-38680][INFRA] Set upperbound for pandas-stubs in CI
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #35996:
URL: https://github.com/apache/spark/pull/35996#issuecomment-1081550688
Makes sense, although we have to be careful not to get to get stuck with out of date annotations here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org