You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/19 09:50:45 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

lordgamez commented on pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#issuecomment-802699210


   > `-DENABLE_SENSORS=ON -DFAIL_ON_WARNINGS=ON` seems to be broken because `thirdparty/RTIMULib` is added with `add_subdirectory`, inherits the `Werror` and has warnings. Not sure if this should be fixed in context of this issue or a new one.
   > 
   > There are also leftover warnings in the JNI extension, but I assume those are out of scope.
   
   Thanks for the heads up. I will have a followup PR with the remaining issues that are not covered in the CI. I think this can be still be part of the same issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org