[GitHub] [flink] docete commented on a change in pull request #11493: [FLINK-16160][table-common] Support computed column, proctime and watermark in Schema descriptor

[GitBox <gi...@apache.org>]

docete commented on a change in pull request #11493: [FLINK-16160][table-common] Support computed column, proctime and watermark in Schema descriptor
URL: https://github.com/apache/flink/pull/11493#discussion_r400628945
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/descriptors/CustomConnectorDescriptor.java
 ##########
 @@ -16,18 +16,16 @@
  * limitations under the License.
  */
 
-package org.apache.flink.table.descriptors.python;
+package org.apache.flink.table.descriptors;
 
-import org.apache.flink.annotation.Internal;
-import org.apache.flink.table.descriptors.ConnectorDescriptor;
-import org.apache.flink.table.descriptors.DescriptorProperties;
+import org.apache.flink.annotation.PublicEvolving;
 
 import java.util.Map;
 
 /**
  * Describes a custom connector to an other system.
  */
-@Internal
+@PublicEvolving
 
 Review comment:
   There are many user-defined table sources (and related factory). I think we should provide a  common Connector Descriptor. Or user must define an extra descriptor for their table source. That's tedious and not user friendly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services