You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2020/04/14 17:01:26 UTC
[Impala-ASF-CR] IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15731
Change subject: IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
......................................................................
IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
RangerAuthContext#getResourceACLs() was deprecated due to a recent
change in RANGER-2654 and the constructor
RangerRESTClient(String, String) of the class RangerRESTClient was
also recently deprecated in RANGER-2646. This patch replaces the
references to these two methods with the updated APIs respectively.
Testing:
- Verified that this patch passes the exhaustive tests in the DEBUG
build.
Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
---
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/15731/1
--
To view, visit http://gerrit.cloudera.org:8080/15731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Gerrit-Change-Number: 15731
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15731 )
Change subject: IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
......................................................................
IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
RangerAuthContext#getResourceACLs() was deprecated due to a recent
change in RANGER-2654 and the constructor
RangerRESTClient(String, String) of the class RangerRESTClient was
also recently deprecated in RANGER-2646. This patch replaces the
references to these two methods with the updated APIs respectively.
Testing:
- Verified that this patch passes the exhaustive tests in the DEBUG
build.
Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Reviewed-on: http://gerrit.cloudera.org:8080/15731
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Gerrit-Change-Number: 15731
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15731 )
Change subject: IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Gerrit-Change-Number: 15731
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 22:37:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15731 )
Change subject: IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Gerrit-Change-Number: 15731
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 18:24:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15731 )
Change subject: IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5651/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Gerrit-Change-Number: 15731
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 18:24:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15731 )
Change subject: IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5805/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Gerrit-Change-Number: 15731
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 17:42:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15731 )
Change subject: IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Gerrit-Change-Number: 15731
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 17:52:07 +0000
Gerrit-HasComments: No