You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/19 19:31:43 UTC
Re: Review Request 42172: Add documentation for the ContainerLogger.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:31 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.
Changes
-------
Removed Rakefile change in lieu of [42457](/r/42457). Note that some links in this doc will appear broken until 42457 is committed.
Summary (updated)
-----------------
Add documentation for the ContainerLogger.
Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206
Repository: mesos
Description (updated)
-------
Add documentation for the ContainerLogger.
Diffs (updated)
-----
docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0
docs/home.md ff797fb050d710283fa7e648515ec75779e58f65
docs/logging.md PRE-CREATION
docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025
Diff: https://reviews.apache.org/r/42172/diff/
Testing
-------
Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```
Thanks,
Joseph Wu
Re: Review Request 42172: Add documentation for logging and
ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Jan. 22, 2016, 11:16 a.m., Neil Conway wrote:
> > Can we also mention the common GLOG configuration options? For example, `GLOG_v`.
Besides `GLOG_v`, what else would you suggest? There are quite a few, but I've only ever set this one specifically.
Note: That one is mentioned here:
https://reviews.apache.org/r/42172/diff/5#file1202582line125
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review115906
-----------------------------------------------------------
On Jan. 19, 2016, 7:41 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 7:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.
>
>
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves (and updates) logging flags from configuration.md into the new logging.md.
>
> Add documentation for the ContainerLogger.
> Adds documentation about logging in Master/Agent/Framework and the ContainerLogger.
>
>
> Diffs
> -----
>
> docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0
> docs/home.md ff797fb050d710283fa7e648515ec75779e58f65
> docs/logging.md PRE-CREATION
> docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025
> src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f
>
> Diff: https://reviews.apache.org/r/42172/diff/
>
>
> Testing
> -------
>
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42172: Add documentation for logging and
ContainerLogger.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review115906
-----------------------------------------------------------
Can we also mention the common GLOG configuration options? For example, `GLOG_v`.
- Neil Conway
On Jan. 20, 2016, 3:41 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 3:41 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.
>
>
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves (and updates) logging flags from configuration.md into the new logging.md.
>
> Add documentation for the ContainerLogger.
> Adds documentation about logging in Master/Agent/Framework and the ContainerLogger.
>
>
> Diffs
> -----
>
> docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0
> docs/home.md ff797fb050d710283fa7e648515ec75779e58f65
> docs/logging.md PRE-CREATION
> docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025
> src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f
>
> Diff: https://reviews.apache.org/r/42172/diff/
>
>
> Testing
> -------
>
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42172: Add documentation for logging and
ContainerLogger.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review115374
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42172]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 20, 2016, 3:41 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 3:41 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.
>
>
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves (and updates) logging flags from configuration.md into the new logging.md.
>
> Add documentation for the ContainerLogger.
> Adds documentation about logging in Master/Agent/Framework and the ContainerLogger.
>
>
> Diffs
> -----
>
> docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0
> docs/home.md ff797fb050d710283fa7e648515ec75779e58f65
> docs/logging.md PRE-CREATION
> docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025
> src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f
>
> Diff: https://reviews.apache.org/r/42172/diff/
>
>
> Testing
> -------
>
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42172: Add documentation for logging and
ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 7:41 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.
Changes
-------
Rename "rotating" to "logrotate" and add the new logrotate flags.
Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206
Repository: mesos
Description
-------
Moves (and updates) logging flags from configuration.md into the new logging.md.
Add documentation for the ContainerLogger.
Adds documentation about logging in Master/Agent/Framework and the ContainerLogger.
Diffs (updated)
-----
docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0
docs/home.md ff797fb050d710283fa7e648515ec75779e58f65
docs/logging.md PRE-CREATION
docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025
src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f
Diff: https://reviews.apache.org/r/42172/diff/
Testing
-------
Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```
Thanks,
Joseph Wu
Re: Review Request 42172: Add documentation for logging and
ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 11:58 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.
Changes
-------
Mirror updates to logging flag docs to the actual flag's help.
Add blurb in new doc about /logging/toggle.
Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206
Repository: mesos
Description
-------
Moves (and updates) logging flags from configuration.md into the new logging.md.
Add documentation for the ContainerLogger.
Adds documentation about logging in Master/Agent/Framework and the ContainerLogger.
Diffs (updated)
-----
docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0
docs/home.md ff797fb050d710283fa7e648515ec75779e58f65
docs/logging.md PRE-CREATION
docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025
src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f
Diff: https://reviews.apache.org/r/42172/diff/
Testing
-------
Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```
Thanks,
Joseph Wu
Re: Review Request 42172: Add documentation for logging and
ContainerLogger.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:35 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.
Changes
-------
Reverted change in summary/description due to change in apply-reviews.py
Summary (updated)
-----------------
Add documentation for logging and ContainerLogger.
Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206
Repository: mesos
Description (updated)
-------
Moves (and updates) logging flags from configuration.md into the new logging.md.
Add documentation for the ContainerLogger.
Adds documentation about logging in Master/Agent/Framework and the ContainerLogger.
Diffs
-----
docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0
docs/home.md ff797fb050d710283fa7e648515ec75779e58f65
docs/logging.md PRE-CREATION
docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025
Diff: https://reviews.apache.org/r/42172/diff/
Testing
-------
Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```
Thanks,
Joseph Wu