You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2017/05/29 13:29:16 UTC

[GitHub] flink issue #4009: [FLINK-6732] Activate strict-checkstyle for flink-java

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/4009
  
    I've created set of changes that remove ~3k checkstyle violations in flink-java. 
    
    I had doubts about changing some `public static final classes` into `private static final classes` e.g in `MinAggregationFunction.java`. Is it safe to do so? Can I check it does not interfere with any part of the system. Or should I just revert it and add appropriate javadoc?
    
    @zentol What is your opinion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---