[GitHub] [solr] dsmiley commented on a diff in pull request #1047: SOLR-16229: Abort requests on exception

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1047:
URL: https://github.com/apache/solr/pull/1047#discussion_r983848418


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -477,6 +479,13 @@ public NamedList<Object> request(SolrRequest<?> solrRequest, String collection)
             "IOException occured when talking to server at: " + getBaseURL(), cause);
       }
       throw new SolrServerException(cause.getMessage(), cause);
+    } catch (SolrServerException sse) {
+      abortCause = sse;
+      throw sse;
+    } finally {
+      if (abortCause != null) {

Review Comment:
   Doesn't make sense to me; it's not being compared to itself.  I'll report to Sonatype



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org