You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2019/03/07 20:36:16 UTC
[isis] branch 2033-IoC updated: ISIS-2033: commenting remaining
usages of JDO API
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch 2033-IoC
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/2033-IoC by this push:
new 428aeb8 ISIS-2033: commenting remaining usages of JDO API
428aeb8 is described below
commit 428aeb8318ec48fff7eb579e187d5606a6acc56c
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Mar 7 21:36:08 2019 +0100
ISIS-2033: commenting remaining usages of JDO API
also moving MetricServiceDefault to 'jdo-common'
Task-Url: https://issues.apache.org/jira/browse/ISIS-2033
---
core/config/pom.xml | 2 ++
core/metamodel/pom.xml | 1 +
.../isis/core/runtime/services/metrics/MetricsServiceDefault.java | 0
core/runtime/pom.xml | 3 ++-
4 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/core/config/pom.xml b/core/config/pom.xml
index 415e0cd..d392e9d 100644
--- a/core/config/pom.xml
+++ b/core/config/pom.xml
@@ -66,6 +66,8 @@
<!-- [2039] only to discover persistence capable classes, not required if every
relevant entity is annotated with @DomainObject-->
+ <!-- [2033] as soon as we leave bean/type discovery to the CDI container,
+ we can intercept type scanning an register on the fly -->
<dependency>
<groupId>javax.jdo</groupId>
<artifactId>jdo-api</artifactId>
diff --git a/core/metamodel/pom.xml b/core/metamodel/pom.xml
index 1d0d2dc..824f97b 100644
--- a/core/metamodel/pom.xml
+++ b/core/metamodel/pom.xml
@@ -56,6 +56,7 @@
<dependencies>
<!-- JDO API (non transient, provided by plugin) -->
+ <!-- [2033] only remaining usage is in Annotations to check for javax.jdo.annotations.Column.class -->
<dependency>
<groupId>javax.jdo</groupId>
<artifactId>jdo-api</artifactId>
diff --git a/core/runtime/src/main/java/org/apache/isis/core/runtime/services/metrics/MetricsServiceDefault.java b/core/plugins/jdo-common/src/main/java/org/apache/isis/core/runtime/services/metrics/MetricsServiceDefault.java
similarity index 100%
rename from core/runtime/src/main/java/org/apache/isis/core/runtime/services/metrics/MetricsServiceDefault.java
rename to core/plugins/jdo-common/src/main/java/org/apache/isis/core/runtime/services/metrics/MetricsServiceDefault.java
diff --git a/core/runtime/pom.xml b/core/runtime/pom.xml
index 226bed1..d12318f 100644
--- a/core/runtime/pom.xml
+++ b/core/runtime/pom.xml
@@ -60,11 +60,12 @@
<dependencies>
<!-- JDO API (non transient, provided by plugin) -->
+ <!-- [2033] goal is to not depend on JDO any longer, meaning we want abstract away if possible -->
<dependency>
<groupId>javax.jdo</groupId>
<artifactId>jdo-api</artifactId>
<version>${jdo-api.version}</version>
- <!-- provided by plugins -->
+ provided by plugins
<scope>provided</scope>
</dependency>