You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2023/07/25 11:02:00 UTC
[jira] [Comment Edited] (CASSANDRA-17951) Update AssertJ
[ https://issues.apache.org/jira/browse/CASSANDRA-17951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746911#comment-17746911 ]
Stefan Miklosovic edited comment on CASSANDRA-17951 at 7/25/23 11:01 AM:
-------------------------------------------------------------------------
Thank you, [~skokoori] for the patch. As I was looking into that here (1), I am curious about the reason you introduced changes into
test/burn/org/apache/cassandra/concurrent/LongOpOrderTest.java
test/burn/org/apache/cassandra/transport/SimpleClientPerfTest.java
It seems to me that these changes are more or less just about the code style, no? The changes are not actually fixing anything. If I write this
{code}
assertThat(exec.isShutdown()).isTrue();
{code}
that is equivalent to what it was before:
{code}
assertTrue(exec.isShutdown());
{code}
Is there some intrinsic reason this was changed? I would rather change only the code which is truly blocking us from the upgrade rather then adding these changes. We might probably find a lot of examples in the code base which might be rewritten like this but they are not (in this patch).
(1) https://github.com/apache/cassandra/pull/2511/files
was (Author: smiklosovic):
Thank you, [~skokoori] for the patch. As I was looking into that here, I am curious about the reason you introduced changes into
test/burn/org/apache/cassandra/concurrent/LongOpOrderTest.java
test/burn/org/apache/cassandra/transport/SimpleClientPerfTest.java
It seems to me that these changes are more or less just about the code style, no? The changes are not actually fixing anything. If I write this
{code}
assertThat(exec.isShutdown()).isTrue();
{code}
that is equivalent to what it was before:
{code}
assertTrue(exec.isShutdown());
{code}
Is there some intrinsic reason this was changed? I would rather change only the code which is truly blocking us from the upgrade rather then adding these changes. We might probably find a lot of examples in the code base which might be rewritten like this but they are not (in this patch).
(1) https://github.com/apache/cassandra/pull/2511/files
> Update AssertJ
> --------------
>
> Key: CASSANDRA-17951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17951
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
> Reporter: Ekaterina Dimitrova
> Assignee: shylaja kokoori
> Priority: Normal
> Fix For: 5.x
>
> Attachments: 17951.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> From the changelog of AssertJ [here,|https://assertj.github.io/doc/#assertj-core-3-23-1-release-notes] it seems JDK17 is tested and relevant issues fixed as per 3.23.1, and we are on 3.15.0
> This ticket should accommodate an upgrade to the latest version of AssertJ for trunk.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org