You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/09/10 19:13:17 UTC
[kudu-CR] [cfile] style-guide updates on cfile reader.{h,cc}
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18964
Change subject: [cfile] style-guide updates on cfile_reader.{h,cc}
......................................................................
[cfile] style-guide updates on cfile_reader.{h,cc}
I was looking into the code of the CFileReader::ReadBlock() method while
investigating one compaction issue and took the liberty to update the
code in the corresponding files, making it compliant with the project's
style guide. A follow-up patch makes the code in cfile_reader.{h,cc}
more robust.
There are no functional changes in this patch.
Change-Id: Ib0e900271e7127ea8bbc2c949761f5339740c121
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
2 files changed, 78 insertions(+), 84 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18964/1
--
To view, visit http://gerrit.cloudera.org:8080/18964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0e900271e7127ea8bbc2c949761f5339740c121
Gerrit-Change-Number: 18964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [cfile] style-guide updates on cfile reader.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [cfile] style-guide updates on cfile_reader.{h,cc}
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib0e900271e7127ea8bbc2c949761f5339740c121
Gerrit-Change-Number: 18964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [cfile] style-guide updates on cfile reader.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18964 )
Change subject: [cfile] style-guide updates on cfile_reader.{h,cc}
......................................................................
Patch Set 1: Verified+1
unrelated test failures:
* RELEASE: LocationAwareRebalancingParamTest.Rebalance/idx7_rf2_t3_l_1_2_1
* DEBUG: dist-test failed to submit request
--
To view, visit http://gerrit.cloudera.org:8080/18964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e900271e7127ea8bbc2c949761f5339740c121
Gerrit-Change-Number: 18964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sun, 11 Sep 2022 00:13:31 +0000
Gerrit-HasComments: No
[kudu-CR] [cfile] style-guide updates on cfile reader.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18964 )
Change subject: [cfile] style-guide updates on cfile_reader.{h,cc}
......................................................................
[cfile] style-guide updates on cfile_reader.{h,cc}
I was looking into the code of the CFileReader::ReadBlock() method while
investigating one compaction issue and took the liberty to update the
code in the corresponding files, making it compliant with the project's
style guide. A follow-up patch makes the code in cfile_reader.{h,cc}
more robust.
There are no functional changes in this patch.
Change-Id: Ib0e900271e7127ea8bbc2c949761f5339740c121
Reviewed-on: http://gerrit.cloudera.org:8080/18964
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
2 files changed, 78 insertions(+), 84 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0e900271e7127ea8bbc2c949761f5339740c121
Gerrit-Change-Number: 18964
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [cfile] style-guide updates on cfile reader.{h,cc}
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18964 )
Change subject: [cfile] style-guide updates on cfile_reader.{h,cc}
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e900271e7127ea8bbc2c949761f5339740c121
Gerrit-Change-Number: 18964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sun, 11 Sep 2022 00:07:56 +0000
Gerrit-HasComments: No