[GitHub] merlimat commented on a change in pull request #373: Issue #372: Allow to configure advertised address in bookies

[gi...@git.apache.org]

merlimat commented on a change in pull request #373: Issue #372: Allow to configure advertised address in bookies
URL: https://github.com/apache/bookkeeper/pull/373#discussion_r131253373
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
 ##########
 @@ -586,6 +586,10 @@ public static BookieSocketAddress getBookieAddress(ServerConfiguration conf)
         if (conf.getUseHostNameAsBookieID()) {
             hostAddress = inetAddr.getAddress().getCanonicalHostName();
         }
+
+        if (conf.getAdvertisedAddress() != null && conf.getAdvertisedAddress().trim().length() > 0) {
 
 Review comment:
   Good point, I thought it would make the logic complicated, but actually is better. I've fixed it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services